You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/17 14:28:37 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #55: =str Fix calling `onComplete` twice when downstream cancel.
He-Pin opened a new pull request, #55:
URL: https://github.com/apache/incubator-pekko/pull/55
Try a another way for https://github.com/akka/akka/pull/31630
1. Keep the `onComplete` act as a finalizer
2. Do not call `onComplete` twice when restart
3. pump the option value downstream when restart
4. copied two test cases from https://github.com/akka/akka/pull/31630
In fs2, resource/can be `null`.
```scala
package fs2
import cats.effect.{IO, Resource}
object Test extends App {
val res1: Resource[IO, String] = Resource.make {
println("make")
IO.pure(null)
} { r =>
println("release:" + r)
IO.unit
}
val str: Stream[IO, String] = Stream.resource(res1) ++ Stream.emit("done")
str.compile.toList.unsafeRunAsync{
case Left(value) => println(value)
case Right(value) => println(value)
}(cats.effect.unsafe.implicits.global)
Thread.sleep(3000)
}
```
prints:
```
make
release:null
List(null, done)
```
I don't have a poweradapter now, so maybe can't update until tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695716917
My friend will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1318766572
I think it's not a critical bug and easy to work around, so move to 1.1.0, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695473613
I'm going to close this. There is evidence that the Akka change was looked at and that is a big problem.
We simply cannot look at Akka changes in their BSL licensed versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695492119
The change is from of my PR which I come the fix with the issue reported. And the test case can be dropped with another rewrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1318749951
This should be for 1.1.0, not 1.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] rtar commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by GitBox <gi...@apache.org>.
rtar commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1364460287
I wonder if this is a problem in this case. Giving a link in case you missed it: https://twitter.com/jdegoes/status/1605889036740136965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning closed pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
URL: https://github.com/apache/incubator-pekko/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695501352
At this stage, I think we will need to get someone else to work on this issue. We can't afford even to have the perception that Pekko contributors have looked at BSL Akka code. The only exception is if the PR in Akka was written by the same person who then later contributes it to Pekko.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695485995
We should make a github issue to track this incase someone else wants to implement it, but that "someone" needs to be a person that hasn't looked at the Akka source at all and it should also shouldn't be someone who created this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1332388641
@He-Pin you need to rebase this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #55: =str Fix calling `onComplete` twice when downstream cancel.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #55:
URL: https://github.com/apache/incubator-pekko/pull/55#issuecomment-1695410354
@rtar I don't think that's was a problem because I write the code, And if line by line diff missing , I can adjust it, very simple anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org