You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/04/05 20:05:56 UTC

[GitHub] [lucene] gsmiller commented on a change in pull request #62: LUCENE-9902 Minor fixes to the faceting API

gsmiller commented on a change in pull request #62:
URL: https://github.com/apache/lucene/pull/62#discussion_r607302178



##########
File path: lucene/CHANGES.txt
##########
@@ -287,7 +287,10 @@ Other
 
 API Changes
 ---------------------
-(No changes)
+
+* LUCENE-9902: Change the getValue method from IntTaxonomyFacets to be protected instead of private.

Review comment:
       Looks great! Have you opened up a corresponding PR against the 8x branch in the old repository as well for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org