You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/11/15 08:22:34 UTC

[GitHub] [knox] debiswal commented on pull request #672: KNOX-2833 - Ozone integration for Apache Knox

debiswal commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1314954439

   > Thanks, @debiswal for addressing my direct review comments. There is one more I mentioned above:
   > 
   > > Before we merge your changes, I'd like to ask you to write separate unit test classes for the newly introduced service model generators (there are plenty of samples under the src/test/java folder in the gateway-discovery-cm module.
   > 
   > Without the new test classes, we cannot merge your changes.
   
   @smolnar82 -  Noticed your comments have started looking into it already :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org