You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jgehrcke (via GitHub)" <gi...@apache.org> on 2023/05/06 12:02:22 UTC
[GitHub] [arrow] jgehrcke opened a new pull request, #35467: MINOR: [Go][CI][Benchmarking] Fix 'Run Benchmarks' steps of 'Go' CI check (broken on `main`, fails with `TypeError`)
jgehrcke opened a new pull request, #35467:
URL: https://github.com/apache/arrow/pull/35467
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
As part of https://github.com/apache/arrow/issues/31142 we did not rename `master` to `main` in [`ci/scripts/go_bench_adapt.py`](https://github.com/apache/arrow/blob/b43f4cd4ce28e2ddb7bad89081e141f381b09d5e/ci/scripts/go_bench_adapt.py#L34).
This was not immediately noticed in CI because we accidentally switched to a code branch intended for local dev (cf. the `else:` block [here](https://github.com/apache/arrow/blob/b43f4cd4ce28e2ddb7bad89081e141f381b09d5e/ci/scripts/go_bench_adapt.py#L41)).
Since then we were unintentionally using a feature in conbench/benchadapt to read commit information from the local file system, instead of reading it from CI-focused environment variables.
That even worked for a while.
However, last week, that feature was [removed from benchadapt](https://github.com/conbench/conbench/pull/1135#issuecomment-1537110851) (certainly assuming that this is _not_ used in CI anywhere).
That is also when `BenchmarkResult.github` started to potentially become `None`. Which `mypy` knows about, see:
Well, but further down in code, `parsed.github['commit']` was used w/o protection against this `None` case, and that is how we started to see CI run failures with
```
Traceback (most recent call last):
...
File "/home/runner/work/arrow/arrow/ci/scripts/go_bench_adapt.py", line 94, in _transform_results
parsed.run_name = f"{parsed.run_reason}: {parsed.github['commit']}"
TypeError: 'NoneType' object is not subscriptable
```
See e.g. https://github.com/apache/arrow/actions/runs/4859969743/jobs/8742255231 -- thank you @zeroshade for reporting this.
### What changes are included in this PR?
- Clarification in code via comments
- More expressive variable naming, type hints
- Additional assert statement guarding against running 'local dev' code in CI
- Minor formatting changes via black in VSCode (that's OK I hope?)
A tiny feature/convenience for local dev: the env var `CONBENCH_CUSTOM_RUN_REASON` can be used to inject custom info.
```python
# Reflect 'local dev' scenario in run_reason. Allow user to (optionally)
# inject a custom piece of information into the run reason here, from
# environment.
run_reason = "localdev"
custom_reason_suffix = os.getenv("CONBENCH_CUSTOM_RUN_REASON")
if custom_reason_suffix is not None:
run_reason += f" {custom_reason_suffix.strip()}"
```
### Are these changes tested?
No. Relied on mypy/pylint here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35467: MINOR: [Go][CI][Benchmarking] Fix 'Run Benchmarks' steps of 'Go' CI check (broken on `main`, fails with `TypeError`)
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35467:
URL: https://github.com/apache/arrow/pull/35467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35467: MINOR: [Go][CI][Benchmarking] Fix 'Run Benchmarks' steps of 'Go' CI check (broken on `main`, fails with `TypeError`)
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35467:
URL: https://github.com/apache/arrow/pull/35467#issuecomment-1538790851
Benchmark runs are scheduled for baseline = 2c971511a1f59856b048416ea890743d382c0029 and contender = b98342c000d55c4017571aa549fe56f9c87ebc96. b98342c000d55c4017571aa549fe56f9c87ebc96 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4e4ebce837bf4b4f93cd7721e0aa9c14...a60e955395b946ab95580f61bca41651/)
[Failed :arrow_down:2.22% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2ed96966f9343c3b05240c8370977cd...24872e1f20594b4e9f1ca44025e62882/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ebf3b01026794b3faf8f9442e4c62fcd...812d9dcaa93d47e0a2eded1f1cc93098/)
[Failed :arrow_down:2.86% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2daac6974de949ed9a20f5788b0ee418...baf223be443e4a42867655c059546f6b/)
Buildkite builds:
[Finished] [`b98342c0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2826)
[Failed] [`b98342c0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2863)
[Finished] [`b98342c0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2826)
[Failed] [`b98342c0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2853)
[Finished] [`2c971511` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2825)
[Failed] [`2c971511` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2862)
[Finished] [`2c971511` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2825)
[Failed] [`2c971511` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2852)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org