You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/03 18:39:26 UTC
[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5792: [TE] Refactor Dashboard Server resources and dependencies
suvodeep-pyne opened a new pull request #5792:
URL: https://github.com/apache/incubator-pinot/pull/5792
##Description
This refactor further extends the use of Guice beyond the datalayer by
wrapping all resource classes and dependencies with Guice.
Changes:
- replaces the top level object constructions in the Dashboard Server with Guice.
- All the dependencies have been moved to the Dashboard Server Module.
- Changes in the Resource files mostly involve adding @Inject annotation
- Make the metric registry easily accessible
Possible next steps:
- simplify the resource structure
- convert absolute resource paths to relative paths which make it much easier to manage resources
- refactor the Anomaly Server dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #5792: [TE] Refactor Dashboard Server resources and dependencies
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #5792:
URL: https://github.com/apache/incubator-pinot/pull/5792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5792: [TE] Refactor Dashboard Server resources and dependencies
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on pull request #5792:
URL: https://github.com/apache/incubator-pinot/pull/5792#issuecomment-668283528
Thanks a lot @jihaozh! Yes! I'm planning to do that too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org