You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/04/11 21:06:43 UTC
[GitHub] [superset] justinpark opened a new pull request, #23653: fix(sqllab): rendering performance regression
justinpark opened a new pull request, #23653:
URL: https://github.com/apache/superset/pull/23653
### SUMMARY
When a schema contains a humorous table list, rendering cost of SqlEditorLeftBar is heavy since it requires to iterate millions items. To avoid the lag of using sql editor, we should avoid the LeftBar rendering while typing.
This commit removes the unnecessary immediate `QUERY_EDITOR_SET_SQL` action while typing which triggers the re-rendering of SqlEditorLeftBar.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After (no lag while typing):
https://user-images.githubusercontent.com/1392866/231286835-7c18530d-0fb6-414e-9308-94756c2bede3.mov
Before (typing at same speed):
https://user-images.githubusercontent.com/1392866/231286786-980a7910-c3bc-483c-8a07-e4399bec58d4.mov
### TESTING INSTRUCTIONS
open sqllab with a list of > 100,000 tables
typing in the sql editor
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23653: fix(sqllab): rendering performance regression
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23653:
URL: https://github.com/apache/superset/pull/23653#issuecomment-1504201958
## [Codecov](https://codecov.io/gh/apache/superset/pull/23653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23653](https://codecov.io/gh/apache/superset/pull/23653?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af6ebaf) into [master](https://codecov.io/gh/apache/superset/commit/825006d90656f4955e71062803fbcb7ef7fb5659?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (825006d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head af6ebaf differs from pull request most recent head b7edd68. Consider uploading reports for the commit b7edd68 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23653 +/- ##
=======================================
Coverage 67.93% 67.94%
=======================================
Files 1918 1918
Lines 73891 73890 -1
Branches 8058 8058
=======================================
+ Hits 50199 50204 +5
+ Misses 21633 21625 -8
- Partials 2059 2061 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.90% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/23653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `58.60% <ø> (+1.91%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23653/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #23653: fix(sqllab): rendering performance regression
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23653:
URL: https://github.com/apache/superset/pull/23653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org