You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Hyrum K Wright <hy...@wandisco.com> on 2012/02/02 14:13:46 UTC

Re: svn commit: r1239553 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h svn/diff-cmd.c svn/log-cmd.c svn/main.c

On Thu, Feb 2, 2012 at 5:35 AM,  <st...@apache.org> wrote:
> Author: stsp
> Date: Thu Feb  2 11:35:09 2012
> New Revision: 1239553
>
> URL: http://svn.apache.org/viewvc?rev=1239553&view=rev
> Log:
> Add --no-diff-properties and --patch options to 'svn diff'.
> The --patch option implies --no-diff-properties and --show-copies-as-adds.

Bikeshed: since the fact that we are using diff is implied by the
subcommand, would it be reasonable to use a more generic option name,
such as '--ignore-props' instead of '--no-diff-properties'.  It is
shorter firstly, and second it could be reused for other options, such
as log, or event commit.

I agree about the utility of the feature in general.

-Hyrum


-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Re: svn commit: r1239553 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h svn/diff-cmd.c svn/log-cmd.c svn/main.c

Posted by Stefan Sperling <st...@elego.de>.
On Thu, Feb 02, 2012 at 07:13:46AM -0600, Hyrum K Wright wrote:
> Bikeshed: since the fact that we are using diff is implied by the
> subcommand, would it be reasonable to use a more generic option name,
> such as '--ignore-props' instead of '--no-diff-properties'.  It is
> shorter firstly, and second it could be reused for other options, such
> as log, or event commit.
> 
> I agree about the utility of the feature in general.

The name was based on --no-diff-deleted.
I agree that --ignore-props would be good, too.

Re: svn commit: r1239553 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h svn/diff-cmd.c svn/log-cmd.c svn/main.c

Posted by Stefan Sperling <st...@elego.de>.
On Thu, Feb 02, 2012 at 07:13:46AM -0600, Hyrum K Wright wrote:
> Bikeshed: since the fact that we are using diff is implied by the
> subcommand, would it be reasonable to use a more generic option name,
> such as '--ignore-props' instead of '--no-diff-properties'.  It is
> shorter firstly, and second it could be reused for other options, such
> as log, or event commit.
> 
> I agree about the utility of the feature in general.

The name was based on --no-diff-deleted.
I agree that --ignore-props would be good, too.