You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/03/10 18:14:17 UTC

Review Request 44653: Fixed formatting in command executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Cleaned up formatting in command executor.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/#review124271
-----------------------------------------------------------


Ship it!




Ship It!

- Ben Mahler


On March 17, 2016, 11:28 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44653/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 11:28 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The general pattern for formatting the code is to
> reduce jaggedness and increase readability.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/44653/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44653: Cleaned up formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 17, 2016, 11:28 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

The general pattern for formatting the code is to
reduce jaggedness and increase readability.


Diffs (updated)
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Cleaned up formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 15, 2016, 3:51 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description (updated)
-------

The general pattern for formatting the code is to
reduce jaggedness and increase readability.


Diffs
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Cleaned up formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 15, 2016, 3:50 p.m.)


Review request for mesos and Ben Mahler.


Summary (updated)
-----------------

Cleaned up formatting in command executor.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Fixed formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 15, 2016, 2:13 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Fixed formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 14, 2016, 5:48 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Fixed formatting in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
-----------------------------------------------------------

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov