You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by yj...@apache.org on 2025/01/13 08:23:22 UTC
(cloudberry) 19/21: Fix GPDB_96_MERGE_FIXME: verify walker works on Sequence node (in nodeFuncs.c)
This is an automated email from the ASF dual-hosted git repository.
yjhjstz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 04d2a5a203543221bbb83918cf76c7fde4c1ab96
Author: Tao Tang <ta...@vmware.com>
AuthorDate: Wed Jun 7 11:53:51 2023 -0400
Fix GPDB_96_MERGE_FIXME: verify walker works on Sequence node (in nodeFuncs.c)
Sequence is GPDB-special node generated by ORCA. It returns tuples from the
last child node only. The walkers in `planstate_tree_walker` to be verified are:
1. walkers in execParallel.c:
- no verification required as gp never touch them.
2. ExplainPreScanNode in explain.c:
- it works. no rels in Sequence so no switch-case entry.
3. ExecShutdownNode in execProcnode.c:
- it works, no special shutdown ops for Sequence
---
src/backend/nodes/nodeFuncs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index e0cb194fee..e1538de8b9 100644
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -4360,7 +4360,6 @@ planstate_tree_walker(PlanState *planstate,
walker, context))
return true;
break;
- /* GPDB_96_MERGE_FIXME: verify walker works on Sequence node */
case T_Sequence:
if (planstate_walk_members(((SequenceState *) planstate)->subplans,
((SequenceState *) planstate)->numSubplans,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org