You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/05/16 20:18:50 UTC

[GitHub] [maven-shared-utils] elharo opened a new pull request, #143: use dependencyManagement

elharo opened a new pull request, #143:
URL: https://github.com/apache/maven-shared-utils/pull/143

   Removes dependency warning but still selects the right version of hamcrest-core in transitive dependencies. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] michael-o commented on pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #143:
URL: https://github.com/apache/maven-shared-utils/pull/143#issuecomment-1554589464

   I don't understand this. If a direct dep uses the wrong version then there is the place to fix? Or do we have a conflict in trans deps here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] elharo commented on pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #143:
URL: https://github.com/apache/maven-shared-utils/pull/143#issuecomment-1554997552

   See https://hamcrest.org/JavaHamcrest/distributables for the detailed explanation.
   
   This is a weird case that crops up when using JUnit 4 with Hamcrest 2 because Hamcrest moved classes around between artifacts in version 2. Without this JUnit 4 will pull hamcrest-core 1.4.x into the tree, which contains some of the same classes as org.hamcrest:hamcrest:2.2. This can cause split package issues. In 2.2 hamcrest-core is an empty jar to override this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-shared-utils] elharo merged pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #143:
URL: https://github.com/apache/maven-shared-utils/pull/143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org