[GitHub] spark issue #14225: [SPARK-16334] Maintain single dictionary per row-batch i...

[ericl <gi...@git.apache.org>]

Github user ericl commented on the issue:

    https://github.com/apache/spark/pull/14225
  
    Looks good to me.
    
    tldr: this PR fixes the [non-encoded, encoded, non-encoded] case, but there is still another issue if the row batch ends with an encoded page, e.g. [non-encoded, encoded, encoded]. Though we were not able to reproduce such a parquet file displaying this behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org