You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Joe Bergmark (JIRA)" <ji...@apache.org> on 2009/10/16 18:58:31 UTC

[jira] Updated: (OWB-143) Decorator matching looks for all bean qualifiers in the list of delegate qualifiers

     [ https://issues.apache.org/jira/browse/OWB-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bergmark updated OWB-143:
-----------------------------

    Attachment: OWB-143.txt

A patch for the matching issue.  It does not address the TODO with parameterized types however.  I need a little more time to investigate that.

I also re-factored the method a little bit, removing the boolean flags and some of the nesting.  For one of the flag conditions I had to pull the inner loop out into a helper method.  Please let me know if you prefer the old format, or would prefer that helper method to be elsewhere.

> Decorator matching looks for all bean qualifiers in the list of delegate qualifiers
> -----------------------------------------------------------------------------------
>
>                 Key: OWB-143
>                 URL: https://issues.apache.org/jira/browse/OWB-143
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Interceptor and Decorators
>            Reporter: Joe Bergmark
>            Assignee: Gurkan Erdogdu
>             Fix For: M4
>
>         Attachments: OWB-143.txt
>
>
> When attempting to match the decorator to a bean, the implementation appears to look for a match for all of the bean qualifiers in the delegate qualifier.  For example if there was a bean annotated with @Named and @RequestScope that implements InterfaceA, the delegate injection point right now would need to look like:
> @Delegate @Default @Any @Named InterfaceA a;
> In order for it to match.
> Currently it does not match parameterized types either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (OWB-143) Decorator matching looks for all bean qualifiers in the list of delegate qualifiers

Posted by Gurkan Erdogdu <cg...@gmail.com>.
Hey Joe,

Thanks. Just one point, we are not using Sun style check style.

Instead of

XXX{
}

we are using

XXX
{
}

I am using attached code formatter in eclipse environment

Thanks again;

--Gurkan

2009/10/16 Joe Bergmark (JIRA) <ji...@apache.org>

>
>     [
> https://issues.apache.org/jira/browse/OWB-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Joe Bergmark updated OWB-143:
> -----------------------------
>
>    Attachment: OWB-143.txt
>
> A patch for the matching issue.  It does not address the TODO with
> parameterized types however.  I need a little more time to investigate that.
>
> I also re-factored the method a little bit, removing the boolean flags and
> some of the nesting.  For one of the flag conditions I had to pull the inner
> loop out into a helper method.  Please let me know if you prefer the old
> format, or would prefer that helper method to be elsewhere.
>
> > Decorator matching looks for all bean qualifiers in the list of delegate
> qualifiers
> >
> -----------------------------------------------------------------------------------
> >
> >                 Key: OWB-143
> >                 URL: https://issues.apache.org/jira/browse/OWB-143
> >             Project: OpenWebBeans
> >          Issue Type: Bug
> >          Components: Interceptor and Decorators
> >            Reporter: Joe Bergmark
> >            Assignee: Gurkan Erdogdu
> >             Fix For: M4
> >
> >         Attachments: OWB-143.txt
> >
> >
> > When attempting to match the decorator to a bean, the implementation
> appears to look for a match for all of the bean qualifiers in the delegate
> qualifier.  For example if there was a bean annotated with @Named and
> @RequestScope that implements InterfaceA, the delegate injection point right
> now would need to look like:
> > @Delegate @Default @Any @Named InterfaceA a;
> > In order for it to match.
> > Currently it does not match parameterized types either.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com