You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by cm...@apache.org on 2021/02/25 20:19:26 UTC
[kafka] branch 2.8 updated: MINOR: fix syntax error in
upgrade_test.py (#10210)
This is an automated email from the ASF dual-hosted git repository.
cmccabe pushed a commit to branch 2.8
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.8 by this push:
new c8fe3a1 MINOR: fix syntax error in upgrade_test.py (#10210)
c8fe3a1 is described below
commit c8fe3a122fb422521df2bc459eec81b9f39dd45b
Author: Ron Dagostino <rd...@confluent.io>
AuthorDate: Thu Feb 25 15:14:38 2021 -0500
MINOR: fix syntax error in upgrade_test.py (#10210)
Reviewers: Colin P. McCabe <cm...@apache.org>
---
tests/kafkatest/tests/core/upgrade_test.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/kafkatest/tests/core/upgrade_test.py b/tests/kafkatest/tests/core/upgrade_test.py
index 183e490..59db68f 100644
--- a/tests/kafkatest/tests/core/upgrade_test.py
+++ b/tests/kafkatest/tests/core/upgrade_test.py
@@ -139,8 +139,9 @@ class TestUpgrade(ProduceConsumeValidateTest):
- Finally, validate that every message acked by the producer was consumed by the consumer
"""
self.zk = ZookeeperService(self.test_context, num_nodes=1, version=KafkaVersion(from_kafka_version))
+ fromKafkaVersion = KafkaVersion(from_kafka_version)
self.kafka = KafkaService(self.test_context, num_nodes=3, zk=self.zk,
- version=KafkaVersion(from_kafka_version),
+ version=fromKafkaVersion,
topics={self.topic: {"partitions": self.partitions,
"replication-factor": self.replication_factor,
'configs': {"min.insync.replicas": 2}}})
@@ -171,7 +172,7 @@ class TestUpgrade(ProduceConsumeValidateTest):
# after leader change. Tolerate limited data loss for this case to avoid transient test failures.
self.may_truncate_acked_records = False if from_kafka_version >= V_0_11_0_0 else True
- new_consumer = from_kafka_version.consumer_supports_bootstrap_server()
+ new_consumer = fromKafkaVersion.consumer_supports_bootstrap_server()
# TODO - reduce the timeout
self.consumer = ConsoleConsumer(self.test_context, self.num_consumers, self.kafka,
self.topic, new_consumer=new_consumer, consumer_timeout_ms=30000,