You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 14:16:25 UTC
[GitHub] [arrow-rs] ritchie46 opened a new pull request #318: Mutablebuffer::shrink_to_fit
ritchie46 opened a new pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318
# Which issue does this PR close?
This PR add `shrink_to_fit` to the public API of `MutableBuffer`. This closes #297.
In line of this, I'd like the option to shrink existing `array` data, where would such logic be a best fit. I was thinking membership of `dyn Array` trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-859323318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-843320071
> Could we add a test? ^_^
Definitely! It was already in the docstring, but I will add an explicit one.
> I am not sure we need inline this; inlining is useful when growing because it is used over an iterator with push; I am not sure it is needed for shrinking
I agree. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-844093699
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#318](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (830d3a8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/c863a2c44bffa5c092a49e07910d5e9225483193?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c863a2c) will **increase** coverage by `0.00%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 162 162
Lines 44007 44021 +14
=======================================
+ Hits 36316 36329 +13
- Misses 7691 7692 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/buffer/mutable.rs](https://codecov.io/gh/apache/arrow-rs/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9tdXRhYmxlLnJz) | `84.34% <92.85%> (+0.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c863a2c...830d3a8](https://codecov.io/gh/apache/arrow-rs/pull/318?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-859460165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan edited a comment on pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-859483345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #318: Mutablebuffer::shrink_to_fit
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org