You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/05/20 15:00:58 UTC
[PR] Move secret_key config to api section [airflow]
pierrejeambrun opened a new pull request, #50839:
URL: https://github.com/apache/airflow/pull/50839
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099851360
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
But still.. the provider can be installed on Airflow 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099829414
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I'm planing to backport this to 3.0.2, similarly to recently moved config to fab provider, since we currently have a constraint on core `3.0.2` (we have constraints on both sides even core and fab) for next wave I think we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #50839:
URL: https://github.com/apache/airflow/pull/50839#issuecomment-2897185885
Helm chart part has been omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099829414
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
To avoid this delay, I'm planing to backport this to 3.0.2, similarly to recently moved config to fab provider, since we currently have a constraint on core `3.0.2` (we have constraints on both sides core => fab, fab => core) for next wave I think we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099854588
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
It can't because there is a lower bound constraint on `3.0.2` core from the fab provider `pyproject.toml`. So the provider can't be installed on 3.0.0. Or I'm missing something. `"apache-airflow>=3.0.2"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099829414
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I'm planing to backport this to 3.0.2, similarly to recently moved config to fab provider, since we currently have a constraint on core `3.0.2` for next wave I think we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099887886
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I understand. The idea is that since we are in super early `3.0.0` release cycle, no `3.1.0` yet, we allow ourselves to be in this gray area. Which isn't ideal, but pretty convenient at this point.
cc: @jedcunningham @potiuk (just to be sure I didn't misinterpreted something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099867312
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
This is the solution we went for with the previous config move. (other PRs, so the bump is already done, that's why i'm no doing anything in this one), we discussed it with Jarek, Jed and you and we agreed that this was the easier way, instead of writing compatibility code.
Discussed in:
- https://github.com/apache/airflow/pull/50208#issuecomment-2875590699
- https://github.com/apache/airflow/pull/50269#issuecomment-2875679246
- https://github.com/apache/airflow/issues/49896#issuecomment-2891759968
(Trying to find the last one with Jed)
Is there an issue with that approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. But if that's necessary I'll do it. (write compat code, remove the lower bound constraint from provider to core)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099867312
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
This is the solution we went for with the previous config move. (other PRs), we discussed it with Jarek, Jed and you and we agreed that this was the easier way, instead of writing compatibility code.
Discussed in:
- https://github.com/apache/airflow/pull/50208#issuecomment-2875590699
- https://github.com/apache/airflow/pull/50269#issuecomment-2875679246
- https://github.com/apache/airflow/issues/49896#issuecomment-2891759968
(Trying to find the last one with Jed)
Is there an issue with that approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. But if that's necessary I'll do it. (write compat code, remove the lower bound constraint from provider to core). And we might need to do the them for stuff moved from core to fab. (compat code in core to not have the constraint over the new version of the fab provider)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #50839:
URL: https://github.com/apache/airflow/pull/50839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. But if that's necessary I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099854588
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
It don'w because there is a lower bound constraint on `3.0.2`. So the provider can't be installed on 3.0.0. Or I'm missing something. `"apache-airflow>=3.0.2"`
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
It can't because there is a lower bound constraint on `3.0.2`. So the provider can't be installed on 3.0.0. Or I'm missing something. `"apache-airflow>=3.0.2"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099855418
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I suggest to avoid this problem by simply try to extract setting from new location and if fails try from old location. Adding a todo to remove the fallback when min airflow version for provider greater than X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. (write compat code, remove the lower bound constraint from provider to core). And we might need to do the them for stuff moved from core to fab. (compat code in core to not have the constraint over the new version of the fab provider)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099883932
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
Unless i am missing something users who run Airflow 3.0.0 won't be able to update fab provider without also updating Airflow core version. This goes against our promise of updating providers seperatly from core.
That said, I am not into the details of the moving configuration wave thus I if it already agreed approch for this migration feel free to continue with what was decided.
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
Unless i am missing something users who run Airflow 3.0.0 won't be able to update fab provider without also updating Airflow core version. This goes against our promise of updating providers separately from core.
That said, I am not into the details of the moving configuration wave thus I if it already agreed approach for this migration feel free to continue with what was decided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. (write compat code, remove the lower bound constraint from provider to core). And we might need to do the them for stuff moved from core to fab. (compat code in core to not have the constraint over the new version of the fab provider)
If the current approach 'works' I suggest we do that because the effort is smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099867312
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
This is the solution we went for with the previous config move. (other PRs, so the bump is already done, that's why i'm no doing anything in this one), we discussed it with Jarek, Jed and you and we agreed (At least it didn't see any pushback) that this was the easier way, instead of writing compatibility code.
Discussed in:
- https://github.com/apache/airflow/pull/50208#issuecomment-2875590699
- https://github.com/apache/airflow/pull/50269#issuecomment-2875679246
- https://github.com/apache/airflow/issues/49896#issuecomment-2891759968
(Trying to find the last one with Jed)
Is there an issue with that approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099829414
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
To avoid this delay, I'm planing to backport this to 3.0.2, similarly to recently moved config to fab provider, since we currently have a constraint on core `3.0.2` (we have constraints on both sides even core and fab) for next wave I think we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099887886
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I understand, the idea is that since we are in super early `3.0.0` release cycle, no `3.1.0` yet, we allow ourselves to be in this gray area.
cc: @jedcunningham @potiuk (just to be sure I didn't misinterpreted something)
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
I understand. The idea is that since we are in super early `3.0.0` release cycle, no `3.1.0` yet, we allow ourselves to be in this gray area.
cc: @jedcunningham @potiuk (just to be sure I didn't misinterpreted something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099872164
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
We could do what you are saying, but I'd rather not go over the other Prs and change all that at this point. (write compat code, remove the lower bound constraint from provider to core). And we might need to do the same for stuff moved from core to fab. (compat code in core to not have the constraint over the new version of the fab provider)
If the current approach 'works' I suggest we do that because the effort is smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099854588
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
It can't because there is a lower bound constraint on `3.0.2` core from the fab provider `pyproject.toml`. So that new provider version can't be installed on 3.0.0. Or I'm missing something. `"apache-airflow>=3.0.2"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2100186220
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
> I understand. The idea is that since we are in super early 3.0.0 release cycle, no 3.1.0 yet, we allow ourselves to be in this gray area. Which isn't ideal, but pretty convenient at this point.
Yes. That's the idea, it's really because we are bug-fixing issues that we have not seen before we released 3.0.0 and 3.0.1. And yes it means exactly what you say @eladkal,but I consider that as one-time exception only and result of having some left-overs not finished in Airflow 3 - we are cleaning it "now".
Simillary task-sdk is now coupled to Airflow - and we only plan to "free it" when both Airflow 3 and Task SDK reach `X.1.0` verions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #50839:
URL: https://github.com/apache/airflow/pull/50839#issuecomment-2894956293
Marking as draft, will need to split out the chart update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099796943
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
This will make the provider to work only with Airflow 3.1+ isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secret_key config to api section [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2100593330
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
^ Yep, also my view - one time exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org