You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/02/06 21:20:49 UTC
Re: Review Request 65400: Windows: Tied task lifetimes to executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65400/#review196737
-----------------------------------------------------------
Ship it!
- Joseph Wu
On Jan. 29, 2018, 12:34 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65400/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:34 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To enable recovery of checkpointed tasks, the agent must be able to die
> without also killing the executors and tasks, thus we cannot set the
> "job object kill on close" limit unconditionally. However, the executors
> must still be able to kill their tasks when they die, so we explicitly
> enable this limit through a parent hook when launching the container for
> the task. In this way, the agent can be restarted (e.g. for an upgrade)
> without killing the executors, but the executors are still capable of
> killing their tasks on catastrophic death.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
>
>
> Diff: https://reviews.apache.org/r/65400/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>