You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "iemre (via GitHub)" <gi...@apache.org> on 2023/03/17 09:48:54 UTC
[GitHub] [flink-connector-aws] iemre opened a new pull request, #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords
iemre opened a new pull request, #58:
URL: https://github.com/apache/flink-connector-aws/pull/58
We let these exceptions go up the call stack without logging them. This causes these exceptions from the Kinesis connector to be not visible to customers in their logs, despite their visibility in the exceptions tab on Flink UI.
## Purpose of the change
**Current behaviour:** Errors from `getRecords` are shown under the Exceptions tab on the Flink UI. But they don't appear in customer logs.
**Desired behaviour:** Non-retriable errorsfrom `getRecords` are logged in addition to current behaviour.
## Verifying this change
- Added unit tests
## Significant changes
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #58:
URL: https://github.com/apache/flink-connector-aws/pull/58#issuecomment-1475861863
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #58:
URL: https://github.com/apache/flink-connector-aws/pull/58#discussion_r1140050195
##########
flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java:
##########
@@ -313,6 +313,9 @@ public GetRecordsResult getRecords(String shardIterator, int maxRecordsToGet)
} else {
throw ex;
}
+ } catch (RuntimeException ex) {
+ LOG.error(ex.getClass().getName() + ": " + ex.getMessage());
Review Comment:
Why not `LOG.error(ex)`, or something with a meaningful message `LOG.error("Encountered non-recoverable error while invoking getRecords.", ex);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer merged pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #58:
URL: https://github.com/apache/flink-connector-aws/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #58:
URL: https://github.com/apache/flink-connector-aws/pull/58#issuecomment-1473550834
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org