You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/09 15:50:39 UTC
[GitHub] [dubbo-go] zouyx commented on a change in pull request #855: Remove unmeaning logic
zouyx commented on a change in pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#discussion_r519914066
##########
File path: registry/zookeeper/registry.go
##########
@@ -290,20 +290,17 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL
var zkListener *RegistryConfigurationListener
r.dataListener.mutex.Lock()
+ defer r.dataListener.mutex.Unlock()
Review comment:
If this lock use defer, will include [listenerLock](https://github.com/apache/dubbo-go/blob/234633932aab82913ede37c3f32c7a48a912b869/registry/zookeeper/registry.go#L309), is it right logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org