[PR] fix(zipkin): honour the Query cold stage toggle on Zipkin traces, and read a trace's age in days [skywalking-horizon-ui]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng opened a new pull request, #157:
URL: https://github.com/apache/skywalking-horizon-ui/pull/157

   ## Why
   
   The topbar's **Query cold stage** toggle is documented as applying to traces, and the UI sends it on every request. On the Zipkin path the BFF dropped it: the Zipkin Traces tab and its trace detail read the hot stage whatever the toggle said, and said nothing about it. OAP's Zipkin-compatible API has taken `coldStage`, `endTs` and `lookback` as its own additions for a while, so the gap was one route in Horizon.
   
   ## What
   
   **BFF.** The Zipkin list and trace-by-id routes, the Zipkin branches of the trace routes and the Explore page's Zipkin list send `coldStage=true` while the toggle is on. The layer trace route's Zipkin branch also forwards the window the page asked for, which it used to drop for a thirty-minute default. A by-id lookup carries the window the trace was listed or pasted in as `endTs` and `lookback`: any of the three makes OAP bound the lookup, and a cold trace is by definition older than the day OAP searches by default. The trace route's Zipkin by-id branch also queried the GraphQL port, because the Zipkin and GraphQL option objects type-check alike; it asks the Zipkin base now. Both Zipkin routes take their place in the cold-scope table in `apps/bff/CLAUDE.md`.
   
   **UI.** The Zipkin tab's detail fallback and its paste-an-id popout pass the tab's committed window through (frozen at the run, not read as *now* later), the Explore page's Zipkin detail is bounded by the window its list was read with, and the popout keeps the window in the address (`traceEnd` + `traceLookback`, or `traceAt` for half a day either side of a row's moment, as the native popout does). A trace detail's copied link carries the trace's moment, so a shared link to a cold trace still resolves with the toggle on. The cold-stage trap banner now counts the Zipkin trace class among the classes a cold read touches.
   
   **Age.** The trace list wrote an age past a day as a count of hours, `288h ago`. One shared formatter now reads days and hours past a day, hours and minutes under a day, minutes, seconds, and the trace list and the Auth status admin page's last-LDAP-probe time use it.
   
   Docs: the data-retention page says the toggle covers native and Zipkin traces alike; two changelog entries.
   
   ## Validation
   
   - Unit: a BFF wire test asserts the outgoing Zipkin URL for the two routes, the two trace-route branches and the Explore list with the header on and off, the requested window on the layer list, and the Zipkin base for the by-id branch; UI tests for the by-id query string, the popout window, a zero lookback and the formatter. Every suite green: BFF 1,717, UI 939, api-client 167, conversation-view 63; type-check, root lint, license headers.
   - Live against the public demo OAP, whose `zipkinTrace` group keeps eight days hot and thirty cold. Directly on OAP: the last hour lists five traces hot and none cold; a five-day window twelve days back lists none hot and five cold. Through the BFF's Zipkin, layer-trace and Explore routes with the header on and off: the same. In Chromium on the Istio layer's Zipkin tab: the twelve-day-old window shows *No Zipkin traces* with the toggle off and thirty traces with it on, the rows reading `12d 0h ago`; pasting a cold trace id opens the popout with *No spans returned* off and the span waterfall on, the window in the address.
   - One review round by an independent model against the rule book; its two blocking findings (a copied cold-trace link lost its window; Explore's list and detail read different stages), four should-fix items and two nits are all applied.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(zipkin): honour the Query cold stage toggle on Zipkin traces, and read a trace's age in days [skywalking-horizon-ui]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng merged PR #157:
URL: https://github.com/apache/skywalking-horizon-ui/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org