You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/06/07 08:04:03 UTC
Review Request 35188: RANGER-537: next-ID sequence updated after
creating service-id with pre-defined ID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35188/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-537
https://issues.apache.org/jira/browse/RANGER-537
Repository: ranger
Description
-------
next-ID sequence updated after creating service-id with pre-defined ID
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2cae01d
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java e213937
security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 59ab3db
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 8ef9e08
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 9901832
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 4f35ad3
security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java 1affbf7
security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java c33b39d
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 054a0bd
Diff: https://reviews.apache.org/r/35188/diff/
Testing
-------
Verified that creation of service-def without pre-defined ID goes through successfully.
Thanks,
Madhan Neethiraj
Re: Review Request 35188: RANGER-537: next-ID sequence updated after
creating service-id with pre-defined ID
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35188/#review86988
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java
<https://reviews.apache.org/r/35188/#comment139200>
Not sure why we want nextValue - 1. Shouldn't it be INCREMENT by 1
- Don Bosco Durai
On June 7, 2015, 6:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35188/
> -----------------------------------------------------------
>
> (Updated June 7, 2015, 6:04 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-537
> https://issues.apache.org/jira/browse/RANGER-537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> next-ID sequence updated after creating service-id with pre-defined ID
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2cae01d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java e213937
> security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 59ab3db
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 8ef9e08
> security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 9901832
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 4f35ad3
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java 1affbf7
> security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java c33b39d
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 054a0bd
>
> Diff: https://reviews.apache.org/r/35188/diff/
>
>
> Testing
> -------
>
> Verified that creation of service-def without pre-defined ID goes through successfully.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 35188: RANGER-537: next-ID sequence updated after
creating service-id with pre-defined ID
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35188/#review86989
-----------------------------------------------------------
Ship it!
Ship It!
- Don Bosco Durai
On June 7, 2015, 6:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35188/
> -----------------------------------------------------------
>
> (Updated June 7, 2015, 6:04 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-537
> https://issues.apache.org/jira/browse/RANGER-537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> next-ID sequence updated after creating service-id with pre-defined ID
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2cae01d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java e213937
> security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 59ab3db
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 8ef9e08
> security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 9901832
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 4f35ad3
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java 1affbf7
> security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java c33b39d
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 054a0bd
>
> Diff: https://reviews.apache.org/r/35188/diff/
>
>
> Testing
> -------
>
> Verified that creation of service-def without pre-defined ID goes through successfully.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 35188: RANGER-537: next-ID sequence updated after
creating service-id with pre-defined ID
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35188/#review86991
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java
<https://reviews.apache.org/r/35188/#comment139201>
After next 2 statements are executed, calls to seqName.nextval will return the desired value - nextValue
- Madhan Neethiraj
On June 7, 2015, 6:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35188/
> -----------------------------------------------------------
>
> (Updated June 7, 2015, 6:04 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-537
> https://issues.apache.org/jira/browse/RANGER-537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> next-ID sequence updated after creating service-id with pre-defined ID
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2cae01d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java e213937
> security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 59ab3db
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 8ef9e08
> security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 9901832
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 4f35ad3
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java 1affbf7
> security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java c33b39d
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 054a0bd
>
> Diff: https://reviews.apache.org/r/35188/diff/
>
>
> Testing
> -------
>
> Verified that creation of service-def without pre-defined ID goes through successfully.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>