You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 20:40:46 UTC

[GitHub] [spark] MaxGekk commented on issue #26327: [WIP][SPARK-29669][SQL] Refactor IntervalUtils.fromDayTimeString()

MaxGekk commented on issue #26327: [WIP][SPARK-29669][SQL] Refactor IntervalUtils.fromDayTimeString()
URL: https://github.com/apache/spark/pull/26327#issuecomment-548102964
 
 
   The build https://github.com/apache/spark/pull/26327#issuecomment-548087401 fails on: `'1 2:03' day to hour` because groups in the regexp are floating:
   1. hour can be bound to group 5 https://github.com/apache/spark/blob/dc987f0c8b864208cd1e157f84b997b6c43b68cd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala#L210
   2. or to group 6: https://github.com/apache/spark/blob/dc987f0c8b864208cd1e157f84b997b6c43b68cd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala#L217
   The is a weird regexp :-E 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org