You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Scott Deboy <sc...@gmail.com> on 2018/03/15 19:58:17 UTC
Re-enable appbundle-maven-plugin in Chainsaw build
Hi Matt,
Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS packaging step
Looks like you disabled this to get jenkins working? Has a comment:
"FIXME: make this plugin optional"
Can you re-enable it? Optional is fine, I test with this all the time.
Thanks,
Scott
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Matt Sicker <bo...@gmail.com>.
I've added a pipeline for the parent pom. For now, add -Pdevelopment to
enable the apache snapshots repo (I added that flag to the jenkins build)
unless you install logging-parent locally.
On 16 March 2018 at 09:14, Matt Sicker <bo...@gmail.com> wrote:
> Alright, remaining hurdle right now is that I've upgraded this to use
> logging-parent version 2 which isn't released yet. I'm going to work on
> setting up a Jenkins pipeline for it as well so everything builds properly,
> though I'll make a proper release of the parent pom over the weekend.
>
> On 16 March 2018 at 08:44, Matt Sicker <bo...@gmail.com> wrote:
>
>> Oh wow I didn't notice that you had to include it inside a <build/>
>> element. Thanks! I'll add it as an automatic profile for macOS.
>>
>> On 15 March 2018 at 16:29, Robert Middleton <os...@gmail.com> wrote:
>>
>>> To add a build plugin inside a profile, it should be as simple as the
>>> following:
>>>
>>> <profiles>
>>> <profile>
>>> <id>osx-build</id>
>>> <build>
>>> <plugins>
>>> <plugin>
>>> <groupId>sh.tak.appbundler</groupId>
>>> <artifactId>appbundle-maven-plugin</artifactId>
>>> ... other plugin information here ...
>>> </plugin>
>>> </plugins>
>>> </build>
>>> </profile>
>>> </profiles>
>>>
>>> I just had to do this the other day, not with a DMG builder but with
>>> the maven-assembly-plugin. So I'm reasonably sure that this will work
>>> as-is.
>>>
>>> It should package t with: mvn -P osx-build package appbundle:bundle
>>>
>>> -Robert Middleton
>>>
>>> On Thu, Mar 15, 2018 at 5:06 PM, Scott Deboy <sc...@gmail.com>
>>> wrote:
>>> > I don't know how to fix it, but would like to be able to build
>>> > DMGs...is there an alternative to reverting this change until we can
>>> > figure out how to get both?
>>> >
>>> > On 3/15/18, Matt Sicker <bo...@gmail.com> wrote:
>>> >> I wasn't able to figure out how to do it. I can't seem to add a build
>>> >> plugin inside a profile. Do you know how? I only discovered this
>>> issue when
>>> >> writing the Jenkinsfile since I build it on macOS locally (and while
>>> >> releasing).
>>> >>
>>> >> On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
>>> >>
>>> >>> Hi Matt,
>>> >>>
>>> >>> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS
>>> packaging
>>> >>> step
>>> >>>
>>> >>> Looks like you disabled this to get jenkins working? Has a comment:
>>> >>> "FIXME: make this plugin optional"
>>> >>>
>>> >>> Can you re-enable it? Optional is fine, I test with this all the
>>> time.
>>> >>>
>>> >>> Thanks,
>>> >>>
>>> >>> Scott
>>> >>>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Matt Sicker <bo...@gmail.com>
>>> >>
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Matt Sicker <bo...@gmail.com>.
Alright, remaining hurdle right now is that I've upgraded this to use
logging-parent version 2 which isn't released yet. I'm going to work on
setting up a Jenkins pipeline for it as well so everything builds properly,
though I'll make a proper release of the parent pom over the weekend.
On 16 March 2018 at 08:44, Matt Sicker <bo...@gmail.com> wrote:
> Oh wow I didn't notice that you had to include it inside a <build/>
> element. Thanks! I'll add it as an automatic profile for macOS.
>
> On 15 March 2018 at 16:29, Robert Middleton <os...@gmail.com> wrote:
>
>> To add a build plugin inside a profile, it should be as simple as the
>> following:
>>
>> <profiles>
>> <profile>
>> <id>osx-build</id>
>> <build>
>> <plugins>
>> <plugin>
>> <groupId>sh.tak.appbundler</groupId>
>> <artifactId>appbundle-maven-plugin</artifactId>
>> ... other plugin information here ...
>> </plugin>
>> </plugins>
>> </build>
>> </profile>
>> </profiles>
>>
>> I just had to do this the other day, not with a DMG builder but with
>> the maven-assembly-plugin. So I'm reasonably sure that this will work
>> as-is.
>>
>> It should package t with: mvn -P osx-build package appbundle:bundle
>>
>> -Robert Middleton
>>
>> On Thu, Mar 15, 2018 at 5:06 PM, Scott Deboy <sc...@gmail.com>
>> wrote:
>> > I don't know how to fix it, but would like to be able to build
>> > DMGs...is there an alternative to reverting this change until we can
>> > figure out how to get both?
>> >
>> > On 3/15/18, Matt Sicker <bo...@gmail.com> wrote:
>> >> I wasn't able to figure out how to do it. I can't seem to add a build
>> >> plugin inside a profile. Do you know how? I only discovered this issue
>> when
>> >> writing the Jenkinsfile since I build it on macOS locally (and while
>> >> releasing).
>> >>
>> >> On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
>> >>
>> >>> Hi Matt,
>> >>>
>> >>> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS
>> packaging
>> >>> step
>> >>>
>> >>> Looks like you disabled this to get jenkins working? Has a comment:
>> >>> "FIXME: make this plugin optional"
>> >>>
>> >>> Can you re-enable it? Optional is fine, I test with this all the
>> time.
>> >>>
>> >>> Thanks,
>> >>>
>> >>> Scott
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Matt Sicker <bo...@gmail.com>
>> >>
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Matt Sicker <bo...@gmail.com>.
Oh wow I didn't notice that you had to include it inside a <build/>
element. Thanks! I'll add it as an automatic profile for macOS.
On 15 March 2018 at 16:29, Robert Middleton <os...@gmail.com> wrote:
> To add a build plugin inside a profile, it should be as simple as the
> following:
>
> <profiles>
> <profile>
> <id>osx-build</id>
> <build>
> <plugins>
> <plugin>
> <groupId>sh.tak.appbundler</groupId>
> <artifactId>appbundle-maven-plugin</artifactId>
> ... other plugin information here ...
> </plugin>
> </plugins>
> </build>
> </profile>
> </profiles>
>
> I just had to do this the other day, not with a DMG builder but with
> the maven-assembly-plugin. So I'm reasonably sure that this will work
> as-is.
>
> It should package t with: mvn -P osx-build package appbundle:bundle
>
> -Robert Middleton
>
> On Thu, Mar 15, 2018 at 5:06 PM, Scott Deboy <sc...@gmail.com>
> wrote:
> > I don't know how to fix it, but would like to be able to build
> > DMGs...is there an alternative to reverting this change until we can
> > figure out how to get both?
> >
> > On 3/15/18, Matt Sicker <bo...@gmail.com> wrote:
> >> I wasn't able to figure out how to do it. I can't seem to add a build
> >> plugin inside a profile. Do you know how? I only discovered this issue
> when
> >> writing the Jenkinsfile since I build it on macOS locally (and while
> >> releasing).
> >>
> >> On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
> >>
> >>> Hi Matt,
> >>>
> >>> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS packaging
> >>> step
> >>>
> >>> Looks like you disabled this to get jenkins working? Has a comment:
> >>> "FIXME: make this plugin optional"
> >>>
> >>> Can you re-enable it? Optional is fine, I test with this all the time.
> >>>
> >>> Thanks,
> >>>
> >>> Scott
> >>>
> >>
> >>
> >>
> >> --
> >> Matt Sicker <bo...@gmail.com>
> >>
>
--
Matt Sicker <bo...@gmail.com>
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Robert Middleton <os...@gmail.com>.
To add a build plugin inside a profile, it should be as simple as the following:
<profiles>
<profile>
<id>osx-build</id>
<build>
<plugins>
<plugin>
<groupId>sh.tak.appbundler</groupId>
<artifactId>appbundle-maven-plugin</artifactId>
... other plugin information here ...
</plugin>
</plugins>
</build>
</profile>
</profiles>
I just had to do this the other day, not with a DMG builder but with
the maven-assembly-plugin. So I'm reasonably sure that this will work
as-is.
It should package t with: mvn -P osx-build package appbundle:bundle
-Robert Middleton
On Thu, Mar 15, 2018 at 5:06 PM, Scott Deboy <sc...@gmail.com> wrote:
> I don't know how to fix it, but would like to be able to build
> DMGs...is there an alternative to reverting this change until we can
> figure out how to get both?
>
> On 3/15/18, Matt Sicker <bo...@gmail.com> wrote:
>> I wasn't able to figure out how to do it. I can't seem to add a build
>> plugin inside a profile. Do you know how? I only discovered this issue when
>> writing the Jenkinsfile since I build it on macOS locally (and while
>> releasing).
>>
>> On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
>>
>>> Hi Matt,
>>>
>>> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS packaging
>>> step
>>>
>>> Looks like you disabled this to get jenkins working? Has a comment:
>>> "FIXME: make this plugin optional"
>>>
>>> Can you re-enable it? Optional is fine, I test with this all the time.
>>>
>>> Thanks,
>>>
>>> Scott
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Scott Deboy <sc...@gmail.com>.
I don't know how to fix it, but would like to be able to build
DMGs...is there an alternative to reverting this change until we can
figure out how to get both?
On 3/15/18, Matt Sicker <bo...@gmail.com> wrote:
> I wasn't able to figure out how to do it. I can't seem to add a build
> plugin inside a profile. Do you know how? I only discovered this issue when
> writing the Jenkinsfile since I build it on macOS locally (and while
> releasing).
>
> On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
>
>> Hi Matt,
>>
>> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS packaging
>> step
>>
>> Looks like you disabled this to get jenkins working? Has a comment:
>> "FIXME: make this plugin optional"
>>
>> Can you re-enable it? Optional is fine, I test with this all the time.
>>
>> Thanks,
>>
>> Scott
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: Re-enable appbundle-maven-plugin in Chainsaw build
Posted by Matt Sicker <bo...@gmail.com>.
I wasn't able to figure out how to do it. I can't seem to add a build
plugin inside a profile. Do you know how? I only discovered this issue when
writing the Jenkinsfile since I build it on macOS locally (and while
releasing).
On 15 March 2018 at 14:58, Scott Deboy <sc...@gmail.com> wrote:
> Hi Matt,
>
> Re: 1123826836323a94d73355f0f6d7fd39466ad657 - Disable macOS packaging
> step
>
> Looks like you disabled this to get jenkins working? Has a comment:
> "FIXME: make this plugin optional"
>
> Can you re-enable it? Optional is fine, I test with this all the time.
>
> Thanks,
>
> Scott
>
--
Matt Sicker <bo...@gmail.com>