You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/12/03 03:43:19 UTC
[kudu-CR] [thirdparty] build RocksDB without liburing
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19317
Change subject: [thirdparty] build RocksDB without liburing
......................................................................
[thirdparty] build RocksDB without liburing
As of 7.7.3 version, RocksDB picks up liburing by default if it's
present on the build machine, and it doesn't error out if the library
isn't found. Since we don't yet have the liburing in Kudu's thirdparty,
that might result in unpredictable run-time dependencies.
For now, let's explicitly disable building RocksDB with liburing to
have more predictable build outcomes with RocksDB. Probably, at some
point it makes sense add liburing to Kudu's thirdparty and re-enable
building RocksDB with liburing if performance tests show much better
results when using the library.
Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/19317/1
--
To view, visit http://gerrit.cloudera.org:8080/19317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
Gerrit-Change-Number: 19317
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] build RocksDB without liburing
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19317 )
Change subject: [thirdparty] build RocksDB without liburing
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
Gerrit-Change-Number: 19317
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 04:32:38 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] build RocksDB without liburing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19317 )
Change subject: [thirdparty] build RocksDB without liburing
......................................................................
[thirdparty] build RocksDB without liburing
As of 7.7.3 version, RocksDB picks up liburing by default if it's
present on the build machine, and it doesn't error out if the library
isn't found. Since we don't yet have the liburing in Kudu's thirdparty,
that might result in unpredictable run-time dependencies.
For now, let's explicitly disable building RocksDB with liburing to
have more predictable build outcomes with RocksDB. Probably, at some
point it makes sense add liburing to Kudu's thirdparty and re-enable
building RocksDB with liburing if performance tests show much better
results when using the library.
Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
Reviewed-on: http://gerrit.cloudera.org:8080/19317
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
Gerrit-Change-Number: 19317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>