You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "924060929 (via GitHub)" <gi...@apache.org> on 2026/01/19 03:33:23 UTC
[PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
924060929 opened a new pull request, #60012:
URL: https://github.com/apache/doris/pull/60012
### What problem does this PR solve?
sql cache should check enable_strong_consistency_read
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [x] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766333090
<details>
<summary>TPC-DS: <b>Total hot run time: 174076 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e460f6a977fc3f322527f6230e6264b1af5b1ff, data reload: false
query5 4416 630 478 478
query6 328 237 214 214
query7 4224 466 266 266
query8 345 258 241 241
query9 8709 2891 2875 2875
query10 495 393 325 325
query11 15073 15366 14874 14874
query12 177 116 120 116
query13 1265 483 411 411
query14 6056 3021 2784 2784
query14_1 2701 2651 2669 2651
query15 198 192 180 180
query16 998 471 457 457
query17 1095 659 560 560
query18 2435 436 341 341
query19 221 221 203 203
query20 119 118 113 113
query21 220 142 127 127
query22 3844 3821 3896 3821
query23 15909 15756 15445 15445
query23_1 15488 15477 15373 15373
query24 7176 1557 1185 1185
query24_1 1192 1206 1179 1179
query25 538 444 411 411
query26 1235 268 158 158
query27 2761 444 275 275
query28 4578 2180 2179 2179
query29 787 549 435 435
query30 314 230 206 206
query31 806 642 562 562
query32 86 78 76 76
query33 532 363 315 315
query34 912 880 546 546
query35 710 757 676 676
query36 902 898 828 828
query37 145 97 88 88
query38 2806 2692 2683 2683
query39 775 743 775 743
query39_1 732 707 712 707
query40 221 141 126 126
query41 72 82 67 67
query42 104 104 103 103
query43 430 455 457 455
query44 1306 788 760 760
query45 193 189 182 182
query46 869 941 566 566
query47 1315 1473 1370 1370
query48 308 316 253 253
query49 593 426 337 337
query50 616 262 206 206
query51 3756 3731 3774 3731
query52 103 105 93 93
query53 287 319 268 268
query54 288 259 250 250
query55 81 81 76 76
query56 298 300 291 291
query57 1017 966 895 895
query58 261 257 256 256
query59 2029 2157 1966 1966
query60 332 323 317 317
query61 152 146 146 146
query62 376 359 308 308
query63 294 268 267 267
query64 4877 1285 945 945
query65 3776 3730 3764 3730
query66 1459 412 316 316
query67 15634 15770 15429 15429
query68 2435 1104 781 781
query69 463 363 328 328
query70 1018 985 935 935
query71 332 302 288 288
query72 5321 3406 3221 3221
query73 597 702 321 321
query74 8719 8720 8604 8604
query75 2722 2818 2526 2526
query76 2280 1064 655 655
query77 356 358 304 304
query78 9846 9791 9100 9100
query79 1744 926 586 586
query80 1311 561 498 498
query81 534 261 235 235
query82 972 151 110 110
query83 319 257 239 239
query84 247 117 91 91
query85 887 481 430 430
query86 406 291 292 291
query87 2869 2895 2754 2754
query88 3505 2593 2560 2560
query89 377 348 320 320
query90 1980 176 166 166
query91 161 170 131 131
query92 77 75 71 71
query93 1068 895 557 557
query94 638 315 298 298
query95 567 340 379 340
query96 639 502 229 229
query97 2344 2365 2332 2332
query98 227 199 203 199
query99 597 579 500 500
Total cold run time: 247011 ms
Total hot run time: 174076 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3767806351
# FE Regression Coverage Report
Increment line coverage ` 28.57% (2/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60012_9e460f6a977fc3f322527f6230e6264b1af5b1ff_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60012_9e460f6a977fc3f322527f6230e6264b1af5b1ff_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766342165
<details>
<summary>ClickBench: <b>Total hot run time: 26.92 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e460f6a977fc3f322527f6230e6264b1af5b1ff, data reload: false
query1 0.05 0.04 0.04
query2 0.09 0.04 0.04
query3 0.26 0.08 0.09
query4 1.61 0.12 0.11
query5 0.28 0.26 0.26
query6 1.14 0.65 0.66
query7 0.04 0.02 0.03
query8 0.06 0.04 0.04
query9 0.56 0.50 0.49
query10 0.55 0.56 0.55
query11 0.14 0.10 0.11
query12 0.14 0.11 0.11
query13 0.61 0.58 0.59
query14 0.95 0.94 0.94
query15 0.80 0.77 0.78
query16 0.41 0.39 0.42
query17 1.07 1.04 1.07
query18 0.24 0.21 0.22
query19 1.92 1.78 1.82
query20 0.02 0.02 0.01
query21 15.50 0.25 0.15
query22 5.34 0.06 0.05
query23 16.09 0.28 0.10
query24 1.09 0.65 0.47
query25 0.09 0.09 0.05
query26 0.15 0.13 0.13
query27 0.06 0.08 0.06
query28 5.10 1.07 0.88
query29 12.52 3.93 3.16
query30 0.27 0.14 0.12
query31 2.82 0.64 0.38
query32 3.24 0.55 0.47
query33 2.99 2.99 3.03
query34 16.37 5.08 4.43
query35 4.47 4.44 4.50
query36 0.64 0.52 0.48
query37 0.10 0.07 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.03 0.03
query42 0.05 0.03 0.03
query43 0.05 0.03 0.04
Total cold run time: 98.25 s
Total hot run time: 26.92 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766635787
# FE Regression Coverage Report
Increment line coverage ` 28.57% (2/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60012_9e460f6a977fc3f322527f6230e6264b1af5b1ff_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60012_9e460f6a977fc3f322527f6230e6264b1af5b1ff_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3770679180
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766247249
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766252839
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766313827
<details>
<summary>TPC-H: <b>Total hot run time: 31318 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e460f6a977fc3f322527f6230e6264b1af5b1ff, data reload: false
------ Round 1 ----------------------------------
q1 17620 4285 4059 4059
q2 2035 345 231 231
q3 10196 1231 720 720
q4 10197 809 302 302
q5 7518 2093 1796 1796
q6 189 166 140 140
q7 919 778 656 656
q8 9277 1382 1135 1135
q9 4912 4644 4531 4531
q10 6777 1806 1385 1385
q11 507 292 284 284
q12 712 734 604 604
q13 17782 3817 3111 3111
q14 302 296 284 284
q15 591 525 503 503
q16 691 660 634 634
q17 653 726 545 545
q18 6781 6380 6594 6380
q19 1242 967 606 606
q20 383 348 242 242
q21 2973 2435 2198 2198
q22 1044 1040 972 972
Total cold run time: 103301 ms
Total hot run time: 31318 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4073 4055 4012 4012
q2 300 405 325 325
q3 2105 2574 2175 2175
q4 1329 1731 1330 1330
q5 4117 4006 4099 4006
q6 203 167 130 130
q7 1893 1827 1693 1693
q8 2795 2494 2344 2344
q9 7420 7157 7149 7149
q10 2479 2767 2432 2432
q11 566 465 453 453
q12 700 762 671 671
q13 3727 4195 3583 3583
q14 303 312 307 307
q15 550 497 496 496
q16 659 671 680 671
q17 1129 1241 1382 1241
q18 8100 7846 7919 7846
q19 856 782 806 782
q20 2048 2080 1978 1978
q21 4443 4196 4188 4188
q22 1052 1061 997 997
Total cold run time: 50847 ms
Total hot run time: 48809 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766247099
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766245143
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60012:
URL: https://github.com/apache/doris/pull/60012#issuecomment-3766244877
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](sql cache) fix enable_strong_consistency_read for sql cache [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 merged PR #60012:
URL: https://github.com/apache/doris/pull/60012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org