You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Suran Jayathilaka (JIRA)" <ji...@apache.org> on 2008/08/11 20:12:45 UTC
[jira] Created: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Convert derbynet/timeslice.java to Junit
----------------------------------------
Key: DERBY-3832
URL: https://issues.apache.org/jira/browse/DERBY-3832
Project: Derby
Issue Type: Task
Components: Test
Reporter: Suran Jayathilaka
Assignee: Suran Jayathilaka
Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3832:
-------------------------------------
Attachment: derby-3832-3.diff
This new patch fixes the sys.out.println that was left in the code unintentionally.
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Attachments: derby-3832-2.diff, derby-3832-3.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622285#action_12622285 ]
Kathey Marsden commented on DERBY-3832:
---------------------------------------
It looks good, except when I ran the test I saw this output:
testTimeSliceCallable_Neg2 DRDA_InvalidValue.U:Invalid value, -2, for timeslice.
I think for this case:
try {
server.setTimeSlice(-2);
} catch (Exception e) {
System.out.println(e.getMessage());
}
Instead of outputting the message to the screen, you should check somthing like.
assertTrue(e.getMessage().indexOf("Invalid value") != -1);
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Attachments: derby-3832-2.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3832:
-------------------------------------
Attachment: derby-3832.diff
This patch converts the timeslice.java tests into JUnit test fixtures and adds them to the NetworkServerControlApiTest testcase. Also removes the master/timeslice.out, derbynet/timeslice.java and derbynet/timeslice_app.properties files.
Please review.
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Attachments: derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden resolved DERBY-3832.
-----------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
Committed with revision 685633
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Fix For: 10.5.0.0
>
> Attachments: derby-3832-2.diff, derby-3832-3.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3832:
----------------------------------
Derby Info: [Patch Available]
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Attachments: derby-3832-2.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Suran Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suran Jayathilaka updated DERBY-3832:
-------------------------------------
Attachment: derby-3832-2.diff
This second patch also includes the removal of derbynet/timeslice from derbynetmats.runall and j9derbynetmats.runall.
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Attachments: derby-3832-2.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3832) Convert derbynet/timeslice.java to
Junit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3832:
--------------------------------------
Derby Info: (was: [Patch Available])
> Convert derbynet/timeslice.java to Junit
> ----------------------------------------
>
> Key: DERBY-3832
> URL: https://issues.apache.org/jira/browse/DERBY-3832
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Suran Jayathilaka
> Assignee: Suran Jayathilaka
> Fix For: 10.5.0.0
>
> Attachments: derby-3832-2.diff, derby-3832-3.diff, derby-3832.diff
>
>
> Convert derbynet/timeslice to a Junit testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.