You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (Created) (JIRA)" <ji...@apache.org> on 2012/04/02 21:35:23 UTC

[jira] [Created] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

TestStatsPublisherEnhanced throws NPE on JDBC connection failure
----------------------------------------------------------------

                 Key: HIVE-2920
                 URL: https://issues.apache.org/jira/browse/HIVE-2920
             Project: Hive
          Issue Type: Bug
          Components: Statistics, Testing Infrastructure
            Reporter: Carl Steinbach
            Assignee: Carl Steinbach




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244876#comment-13244876 ] 

Phabricator commented on HIVE-2920:
-----------------------------------

zhenxiao has commented on the revision "HIVE-2920 [jira] TestStatsPublisherEnhanced throws NPE on JDBC connection failure".

  + 1

REVISION DETAIL
  https://reviews.facebook.net/D2577

                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-2920.D2577.1.patch, HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-2920:
---------------------------------

    Attachment: HIVE-2920.D2577.1.patch
    
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-2920.D2577.1.patch, HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Carl Steinbach (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244501#comment-13244501 ] 

Carl Steinbach commented on HIVE-2920:
--------------------------------------

I have seen intermittent failures in TestStatsPublisherEnhanced with the following stack:

{noformat}
java.lang.NullPointerException
	at org.apache.hadoop.hive.ql.exec.Utilities.prepareWithRetry(Utilities.java:2176)
	at org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator.cleanUp(JDBCStatsAggregator.java:215)
	at org.apache.hadoop.hive.ql.exec.TestStatsPublisherEnhanced.setUp(TestStatsPublisherEnhanced.java:60)
	at junit.framework.TestCase.runBare(TestCase.java:132)
	at junit.framework.TestResult$1.protect(TestResult.java:110)
	at junit.framework.TestResult.runProtected(TestResult.java:128)
	at junit.framework.TestResult.run(TestResult.java:113)
	at junit.framework.TestCase.run(TestCase.java:124)
	at junit.framework.TestSuite.runTest(TestSuite.java:243)
	at junit.framework.TestSuite.run(TestSuite.java:238)
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
	at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)
{noformat}
                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2920:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.0
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks, Carl!
                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2920.D2577.1.patch, HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-2920:
---------------------------------

    Release Note: 


          Status: Patch Available  (was: Open)

This patch moves the StatsAggregator cleanup code from the setUp() method to the tearDown() method in order to insure that it gets called *after* StatsPublisher.init() (which creates some tables that StatsAggregator.connect() depends on). I also added some assert statements to the tearDown() code.
                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-2920.D2577.1.patch, HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245275#comment-13245275 ] 

Hudson commented on HIVE-2920:
------------------------------

Integrated in Hive-trunk-h0.21 #1349 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1349/])
    HIVE-2920 : TestStatsPublisherEnhanced throws NPE on JDBC connection failure (Carl Steinbach via Ashutosh Chauhan) (Revision 1308731)

     Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308731
Files : 
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestStatsPublisherEnhanced.java

                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2920.D2577.1.patch, HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2920) TestStatsPublisherEnhanced throws NPE on JDBC connection failure

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2920:
------------------------------

    Attachment: HIVE-2920.D2577.1.patch

cwsteinbach requested code review of "HIVE-2920 [jira] TestStatsPublisherEnhanced throws NPE on JDBC connection failure".
Reviewers: JIRA

  HIVE-2920. TestStatsPublisherEnhanced throws NPE on JDBC connection failure

TEST PLAN
  NONE

REVISION DETAIL
  https://reviews.facebook.net/D2577

AFFECTED FILES
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestStatsPublisherEnhanced.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/5847/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> TestStatsPublisherEnhanced throws NPE on JDBC connection failure
> ----------------------------------------------------------------
>
>                 Key: HIVE-2920
>                 URL: https://issues.apache.org/jira/browse/HIVE-2920
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics, Testing Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-2920.D2577.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira