[GitHub] [incubator-superset] villebro commented on a change in pull request #9197: [datasets] new, listview (react)

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9197: [datasets] new, listview (react)
URL: https://github.com/apache/incubator-superset/pull/9197#discussion_r390623011
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -440,6 +440,18 @@ def make_sqla_column_compatible(
     def __repr__(self):
         return self.name
 
+    @property
+    def changed_by_name(self):
+        if not self.changed_by:
+            return ""
+        return str(self.changed_by)
+
+    @property
+    def changed_by_url(self):
 
 Review comment:
   here, too: `def changed_by_url(self) -> str:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org