[GitHub] spark pull request #19646: [SPARK-22417][PYTHON] Fix for createDataFrame fro...

[BryanCutler <gi...@git.apache.org>]

Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19646#discussion_r149192058
  
    --- Diff: python/pyspark/sql/session.py ---
    @@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema):
             data = [schema.toInternal(row) for row in data]
             return self._sc.parallelize(data), schema
     
    +    def _getNumpyRecordDtypes(self, rec):
    --- End diff --
    
    yeah, I agree we should be using lowercase with underscores which is more of the convention for python.  I was only using this format to stay consistent with the rest of the file, but I can change it.  Just for the new methods right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org