You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/12 03:22:53 UTC

[GitHub] [shardingsphere] JooKS-me opened a new pull request #11273: Add integration test for opentelemetry plugin

JooKS-me opened a new pull request #11273:
URL: https://github.com/apache/shardingsphere/pull/11273


   Ref #11102 .
   
   Changes proposed in this pull request:
   - Add integration test for opentelemetry plugin
       - Change the code in `OkHttpUtils.java` to meet the use of opentelemetry integration test, but compatible with the it of metrics
       - update `agent.yaml` in metrics integration test
   - Add github action workflow yml code for integration of opentelemetry
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 merged pull request #11273: Add integration test for opentelemetry plugin

Posted by GitBox <gi...@apache.org>.

yu199195 merged pull request #11273:
URL: https://github.com/apache/shardingsphere/pull/11273


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11273: Add integration test for opentelemetry plugin

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #11273:
URL: https://github.com/apache/shardingsphere/pull/11273#issuecomment-877950299


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11273](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc34e87) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d7f68387e40bb8063feb700926ea5ce1f18cf3a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7f6838) will **decrease** coverage by `0.27%`.
   > The diff coverage is `96.05%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11273/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11273      +/-   ##
   ============================================
   - Coverage     63.62%   63.34%   -0.28%     
   - Complexity     1024     1026       +2     
   ============================================
     Files          2177     2200      +23     
     Lines         33348    33601     +253     
     Branches       5842     5880      +38     
   ============================================
   + Hits          21216    21285      +69     
   - Misses        10444    10625     +181     
   - Partials       1688     1691       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...entelemetry/advice/JDBCExecutorCallbackAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvYWR2aWNlL0pEQkNFeGVjdXRvckNhbGxiYWNrQWR2aWNlLmphdmE=) | `91.66% <91.66%> (ø)` | |
   | [...ng/opentelemetry/advice/SQLParserEngineAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvYWR2aWNlL1NRTFBhcnNlckVuZ2luZUFkdmljZS5qYXZh) | `93.33% <93.33%> (ø)` | |
   | [...pentelemetry/advice/CommandExecutorTaskAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvYWR2aWNlL0NvbW1hbmRFeGVjdXRvclRhc2tBZHZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...n/OpenTelemetryTracingPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvZGVmaW5pdGlvbi9PcGVuVGVsZW1ldHJ5VHJhY2luZ1BsdWdpbkRlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...service/OpenTelemetryTracingPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL29wZW50ZWxlbWV0cnkvc2VydmljZS9PcGVuVGVsZW1ldHJ5VHJhY2luZ1BsdWdpbkJvb3RTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ere/scaling/distsql/parser/core/ScalingParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9jb3JlL1NjYWxpbmdQYXJzZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...parser/facade/ScalingSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9mYWNhZGUvU2NhbGluZ1NRTFN0YXRlbWVudFBhcnNlckZhY2FkZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rameterized/engine/SQLParserParameterizedTest.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvZW5naW5lL1NRTFBhcnNlclBhcmFtZXRlcml6ZWRUZXN0LmphdmE=) | `0.00% <0.00%> (-69.57%)` | :arrow_down: |
   | [...serts/segment/parameter/ParameterMarkerAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L3BhcmFtZXRlci9QYXJhbWV0ZXJNYXJrZXJBc3NlcnQuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [.../parameterized/jaxb/sql/loader/SQLCasesLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9zcWwvbG9hZGVyL1NRTENhc2VzTG9hZGVyLmphdmE=) | `16.36% <0.00%> (-45.07%)` | :arrow_down: |
   | ... and [99 more](https://codecov.io/gh/apache/shardingsphere/pull/11273/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [20e7ed4...dc34e87](https://codecov.io/gh/apache/shardingsphere/pull/11273?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org