You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/02/16 19:25:26 UTC
Review Request 73189: RANGER-3147: enhance resource-trie to enable
finding evaluators for a given resource and its children - Part 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73189/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-3147
https://issues.apache.org/jira/browse/RANGER-3147
Repository: ranger
Description
-------
Fixed Path resource matching algorithm for recursive Path policy without wildcard when request scope is SELF_OR_CHILD.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 4a158a276
Diff: https://reviews.apache.org/r/73189/diff/1/
Testing
-------
Passed all unit tests.
Thanks,
Abhay Kulkarni
Re: Review Request 73189: RANGER-3147: enhance resource-trie to enable
finding evaluators for a given resource and its children - Part 2
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73189/#review222600
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 17, 2021, 5:43 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73189/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2021, 5:43 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3147
> https://issues.apache.org/jira/browse/RANGER-3147
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed Path resource matching algorithm for recursive Path policy without wildcard when request scope is SELF_OR_CHILD.
> Removed unused configuration parameter (optSimulateHierarchy).
> Used SELF_OR_CHILD enum consistently in resource-trie search and in path matching algorithm.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequest.java 57804ad09
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java a8ad632af
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 4ebffef61
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 4a158a276
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5c497779d
>
>
> Diff: https://reviews.apache.org/r/73189/diff/2/
>
>
> Testing
> -------
>
> Developed unit tests to test SELF_OR_CHILD scope for PathResourceMatcher. Passed all unit tests.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 73189: RANGER-3147: enhance resource-trie to enable
finding evaluators for a given resource and its children - Part 2
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73189/
-----------------------------------------------------------
(Updated Feb. 17, 2021, 5:43 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Wrote unit tests for SELF_OF_CHILD scope.
Removed unused configuration parameter (optSimulateHierarchy).
Used SELF_OR_CHILD enum consistently in resource-trie search and in path matching algorithm.
Bugs: RANGER-3147
https://issues.apache.org/jira/browse/RANGER-3147
Repository: ranger
Description (updated)
-------
Fixed Path resource matching algorithm for recursive Path policy without wildcard when request scope is SELF_OR_CHILD.
Removed unused configuration parameter (optSimulateHierarchy).
Used SELF_OR_CHILD enum consistently in resource-trie search and in path matching algorithm.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequest.java 57804ad09
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java a8ad632af
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 4ebffef61
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 4a158a276
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5c497779d
Diff: https://reviews.apache.org/r/73189/diff/2/
Changes: https://reviews.apache.org/r/73189/diff/1-2/
Testing (updated)
-------
Developed unit tests to test SELF_OR_CHILD scope for PathResourceMatcher. Passed all unit tests.
Thanks,
Abhay Kulkarni