[GitHub] [apisix] spacewander commented on pull request #3554: feat: add auth hook

[GitBox <gi...@apache.org>]

spacewander commented on pull request #3554:
URL: https://github.com/apache/apisix/pull/3554#issuecomment-775820883


   Before I approve, we need to add some tests as t/plugin/auth-hook.t.
   You can take a look at other tests under t/plugin.
   
   To run the test, you need to install the [test-nginx](https://github.com/iresty/test-nginx).
   You can add a mock auth server in t/lib/server.lua
   
   After running the test, you can find the generated configuration as t/servroot/conf/nginx.conf, and the log is t/servroot/logs/error.log.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org