You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "YannByron (via GitHub)" <gi...@apache.org> on 2023/11/28 13:40:01 UTC

[PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

YannByron opened a new pull request, #2411:
URL: https://github.com/apache/incubator-paimon/pull/2411

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on PR #2411:
URL: https://github.com/apache/incubator-paimon/pull/2411#issuecomment-1830005556

   Once paimon supports `SupportsRuntimeFiltering` to enable dynamic partition pruning, spark requires that the DPP expression must have the same result (see `sameResult` interface in `QueryPlan`) as one `BroadcastExchange` plan. Then `sameResult` will call `BatchExecScan`'s equals method indirectly.
   
   ```
     override def equals(other: Any): Boolean = other match {
       case other: BatchScanExec =>
         this.batch == other.batch && this.runtimeFilters == other.runtimeFilters
       case _ =>
         false
     }
   ```
   
   Here. this `batch` is paimon implementation of `Batch`, so we need to  override `equals` methods related to `Batch`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron closed pull request #2411: [spark] override equals as a preparative step for performance optimization
URL: https://github.com/apache/incubator-paimon/pull/2411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #2411:
URL: https://github.com/apache/incubator-paimon/pull/2411#issuecomment-1829922432

   Can you explain the key to improve performance? Why it is related to equals?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on PR #2411:
URL: https://github.com/apache/incubator-paimon/pull/2411#issuecomment-1829868786

   https://github.com/apache/incubator-paimon/issues/2404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [spark] override equals as a preparative step for performance optimization [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2411:
URL: https://github.com/apache/incubator-paimon/pull/2411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org