You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/11/23 02:10:36 UTC
Re: svn commit: r1037738 - in /subversion/trunk/subversion:
include/ libsvn_client/ svn/ tests/cmdline/ tests/cmdline/svntest/
cmpilato@apache.org wrote on Mon, Nov 22, 2010 at 14:42:06 -0000:
> +++ subversion/trunk/subversion/svn/update-cmd.c Mon Nov 22 14:42:05 2010
> @@ -39,6 +39,42 @@
>
> /*** Code. ***/
>
> +/* Print an update summary when there's more than one target to report
> + about. */
> +static svn_error_t *
> +print_update_summary(apr_array_header_t *targets,
> + apr_array_header_t *result_revs,
> + apr_pool_t *scratch_pool)
> +{
> + int i;
> +
> + if (targets->nelts < 2)
> + return SVN_NO_ERROR;
> +
> + SVN_ERR(svn_cmdline_printf(scratch_pool, _("Summary of updates:\n")));
> +
> + for (i = 0; i < targets->nelts; i++)
> + {
> + const char *path = APR_ARRAY_IDX(targets, i, const char *);
> +
> + if (i < result_revs->nelts)
> + {
> + svn_revnum_t rev = APR_ARRAY_IDX(result_revs, i, const char *);
> +
subversion/svn/update-cmd.c: In function ‘print_update_summary’:
subversion/svn/update-cmd.c:62: warning: initialization makes integer from pointer without a cast
Re: svn commit: r1037738 - in /subversion/trunk/subversion: include/
libsvn_client/ svn/ tests/cmdline/ tests/cmdline/svntest/
Posted by "C. Michael Pilato" <cm...@apache.org>.
On 11/23/2010 09:24 AM, Hyrum K. Wright wrote:
> On Mon, Nov 22, 2010 at 7:10 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>> subversion/svn/update-cmd.c: In function ‘print_update_summary’:
>> subversion/svn/update-cmd.c:62: warning: initialization makes integer from pointer without a cast
>
> I fixed this last night. (Hadn't seen the review, but noticed the
> Windows 'bots weren't building.)
>
> -Hyrum
Thanks for cleaning up after me, guys. Sorry about the mess.
Re: svn commit: r1037738 - in /subversion/trunk/subversion: include/
libsvn_client/ svn/ tests/cmdline/ tests/cmdline/svntest/
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Mon, Nov 22, 2010 at 7:10 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> cmpilato@apache.org wrote on Mon, Nov 22, 2010 at 14:42:06 -0000:
>> +++ subversion/trunk/subversion/svn/update-cmd.c Mon Nov 22 14:42:05 2010
>> @@ -39,6 +39,42 @@
>>
>> /*** Code. ***/
>>
>> +/* Print an update summary when there's more than one target to report
>> + about. */
>> +static svn_error_t *
>> +print_update_summary(apr_array_header_t *targets,
>> + apr_array_header_t *result_revs,
>> + apr_pool_t *scratch_pool)
>> +{
>> + int i;
>> +
>> + if (targets->nelts < 2)
>> + return SVN_NO_ERROR;
>> +
>> + SVN_ERR(svn_cmdline_printf(scratch_pool, _("Summary of updates:\n")));
>> +
>> + for (i = 0; i < targets->nelts; i++)
>> + {
>> + const char *path = APR_ARRAY_IDX(targets, i, const char *);
>> +
>> + if (i < result_revs->nelts)
>> + {
>> + svn_revnum_t rev = APR_ARRAY_IDX(result_revs, i, const char *);
>> +
>
> subversion/svn/update-cmd.c: In function ‘print_update_summary’:
> subversion/svn/update-cmd.c:62: warning: initialization makes integer from pointer without a cast
I fixed this last night. (Hadn't seen the review, but noticed the
Windows 'bots weren't building.)
-Hyrum