You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/06 12:09:51 UTC
[GitHub] [nifi] peetkes opened a new pull request #3956: Added NTLM
Authentication based on presence of NTLM Domain property
peetkes opened a new pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
This pullrequests adds NTLM Authentication support to the InvokeHTTP processor so it can communicate to NTLM authenticated webservices like Sharepoint
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
No
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
No, there is no JIRA Ticket for NTLM Authentication
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
Yes
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
Yes
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-578227599
The code needs to be originally authored OR it needs to be from a source that we can properly account for in terms of its licensing and copyright.
Otherwise we simply cannot accept it. Dont get me wrong - this is great and looks like it would really help folks. But we need originally authored code, or code that is from a category A license group (https://www.apache.org/legal/resolved.html#category-a), or binary dependencies that come from either category A or category B (https://www.apache.org/legal/resolved.html#category-b)
I hope this helps a little more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] peetkes commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
peetkes commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-571655297
Failed tests in modules I did not touch....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] CDann3r commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
CDann3r commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-579521893
I think the issue is that the used httpClient (okhttp3.OkHttpClient) doesn't support NTLM. Therefore two complete java classes have been added which handle the actual NTLM.
I propose to use "org.apache.http.impl.client.HttpClientBuilder" as @simonellistonball did with his WebDAV Processor which is Licensed under Apache2.
Reference => see addAuth method which creates a CredentialProvider for the HttpClientBuilder
[AbstractWebDAVProcessor.java](https://github.com/simonellistonball/nifi-webdav-bundle/blob/master/nifi-webdav-processors/src/main/java/org/apache/nifi/processors/webdav/AbstractWebDAVProcessor.java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] peetkes commented on a change in pull request #3956: Added
NTLM Authentication based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
peetkes commented on a change in pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#discussion_r363626510
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -113,9 +114,10 @@
import static org.apache.commons.lang3.StringUtils.trimToEmpty;
@SupportsBatching
-@Tags({"http", "https", "rest", "client"})
+@Tags({"http", "https", "rest", "client","ntlm"})
@InputRequirement(Requirement.INPUT_ALLOWED)
@CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
+ + " Also supports NTLM authentication to communicate with a sharepoint webservice"
+ " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
Review comment:
Adjusted the Description, works with NTLM in general
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] peetkes commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
peetkes commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-577747094
So what would you need me to do to get this accepted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mdjaniga commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
mdjaniga commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-577855204
believe I found a JIRA ticket for this: NIFI-3096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on a change in pull request #3956:
Added NTLM Authentication based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#discussion_r363383565
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -113,9 +114,10 @@
import static org.apache.commons.lang3.StringUtils.trimToEmpty;
@SupportsBatching
-@Tags({"http", "https", "rest", "client"})
+@Tags({"http", "https", "rest", "client","ntlm"})
@InputRequirement(Requirement.INPUT_ALLOWED)
@CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
+ + " Also supports NTLM authentication to communicate with a sharepoint webservice"
+ " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
Review comment:
Unless NTLM _only_ works with sharepoint, there isn't a need to specify it here. If you _do_ specify it, you might want to capitalize it correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3956: Added NTLM Authentication
based on presence of NTLM Domain property
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #3956: Added NTLM Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#issuecomment-576020293
....this looks like a really great addition. However, it is clearly largely code copied from stackoverflow/etc.. We cannot take such things unless the copyright/licensing is clear. Ideally this comes from some library for which license/attribution is clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services