You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lt964709769 (GitHub)" <gi...@apache.org> on 2019/11/18 12:17:18 UTC
[GitHub] [dubbo] lt964709769 opened pull request #5348: Routing to
the same data center by environment variable configuration
## What is the purpose of the change
Routing to the same data center by environment variable configuration
## Brief changelog
1.Add environment variable configuration (default DUBBO_ROUTER_ENV) .
2.The provider appends the environment variable to the url when it exposes the service.
3.The consumer calls the provider with the same environment variable first in the route.
[ Full content available at: https://github.com/apache/dubbo/pull/5348 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5348: Routing to the
same data center by environment variable configuration
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@ec16ba4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5348 +/- ##
=========================================
Coverage ? 61.22%
Complexity ? 422
=========================================
Files ? 922
Lines ? 37436
Branches ? 5436
=========================================
Hits ? 22922
Misses ? 11997
Partials ? 2517
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `77.47% <0%> (ø)` | `0 <0> (?)` | |
| [...dubbo/rpc/cluster/router/env/EnvRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2Vudi9FbnZSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...apache/dubbo/rpc/cluster/support/ClusterUtils.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9DbHVzdGVyVXRpbHMuamF2YQ==) | `83.72% <100%> (ø)` | `0 <0> (?)` | |
| [...apache/dubbo/rpc/cluster/router/env/EnvRouter.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2Vudi9FbnZSb3V0ZXIuamF2YQ==) | `47.36% <47.36%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/config/EnvRouterAppendParameter.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9FbnZSb3V0ZXJBcHBlbmRQYXJhbWV0ZXIuamF2YQ==) | `47.82% <47.82%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=footer). Last update [ec16ba4...a85bd86](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5348 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5348: Routing to the
same data center by environment variable configuration
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=h1) Report
> Merging [#5348](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/a9746a0ae4f35948442b7d4de889ed3b91e339fe?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5348 +/- ##
===========================================
- Coverage 61.17% 61.1% -0.08%
+ Complexity 424 423 -1
===========================================
Files 919 922 +3
Lines 37487 37535 +48
Branches 5461 5457 -4
===========================================
+ Hits 22933 22935 +2
- Misses 12049 12077 +28
- Partials 2505 2523 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/env/EnvRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2Vudi9FbnZSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...apache/dubbo/rpc/cluster/support/ClusterUtils.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9DbHVzdGVyVXRpbHMuamF2YQ==) | `83.72% <100%> (+0.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `77.47% <33.33%> (-0.61%)` | `0 <0> (ø)` | |
| [...apache/dubbo/rpc/cluster/router/env/EnvRouter.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2Vudi9FbnZSb3V0ZXIuamF2YQ==) | `47.36% <47.36%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/config/EnvRouterAppendParameter.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9FbnZSb3V0ZXJBcHBlbmRQYXJhbWV0ZXIuamF2YQ==) | `47.82% <47.82%> (ø)` | `0 <0> (?)` | |
| [...rg/apache/dubbo/remoting/utils/PayloadDropper.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy91dGlscy9QYXlsb2FkRHJvcHBlci5qYXZh) | `30.76% <0%> (-15.39%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `53.75% <0%> (-3.75%)` | `0% <0%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/dubbo/pull/5348/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=footer). Last update [a9746a0...87248ea](https://codecov.io/gh/apache/dubbo/pull/5348?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5348 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org