Re: [PR] [spark] Support partition DDL for catalog-managed Format Table partitions [paimon]

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #8751:
URL: https://github.com/apache/paimon/pull/8751#discussion_r3619419523


##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/util/OptionUtils.scala:
##########
@@ -186,10 +186,45 @@ object OptionUtils extends SQLConfHelper with Logging {
     if (mergedOptions.isEmpty) {
       table
     } else {
+      normalizeCatalogManagedPartitionOptions(table, mergedOptions)
       table.copy(mergedOptions).asInstanceOf[T]
     }
   }
 
+  /**
+   * Whether a format table's partitions are catalog-managed is a persisted property and cannot be
+   * flipped by a dynamic option. A dynamic {@code metastore.partitioned-table} (typically a
+   * session-global {@code spark.paimon.*} config that used to be a harmless no-op) is dropped so
+   * the persisted value always wins, warning only when it actually disagrees, instead of failing
+   * every format table load in that session.
+   */
+  private def normalizeCatalogManagedPartitionOptions(

Review Comment:
   Do we need this? Just remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org