You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/06 21:46:52 UTC

[GitHub] [helix] narendly opened a new issue #1443: Relax checks in build() in BestPossibleExternalViewVerifier

narendly opened a new issue #1443:
URL: https://github.com/apache/helix/issues/1443


   ### Describe the bug
   `if (_realmAwareZkConnectionConfig == null || _realmAwareZkClientConfig == null) ` Line 144 (line number subject to change)
   
   Here, we do not need the `_realmAwareZkClientConfig == null` condition because if it's not set or null, we call `initializeConfigsIfNull();` anyway to initialize it with default values.
   
   ### To Reproduce
   N/A
   
   ### Expected behavior
   `_realmAwareZkClientConfig` should be optional.
   
   ### Additional context
   While we're at it, we should also review the build() and validate() logic in other subclasses of `ZkHelixClusterVerifier`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org