[GitHub] [incubator-zipkin] adriancole edited a comment on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree

[GitBox <gi...@apache.org>]

adriancole edited a comment on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree 
URL: https://github.com/apache/incubator-zipkin/issues/2616#issuecomment-496535536
 
 
   The dependency graph is an aggregation of remote calls even loopback ones. This includes support for RPC and messaging links as we define them. There are facets to handle some instrumentation problems, however the goal is definitely not to aggregate intermediate/local spans. If we did, it would break everyone who for the last few years have always had remote aggregations.. some sites, this would explode the amount of links for example.
   
   The line you are looking at is relating to a leaf-call to an uninstrumented node (ex client calling a SaaS like an authorization service that isn't traced). Our linker supports creating a virtual link in these circumstances, provided a remote service name exists on the client span.
   
   If there is a bug, it is better to use a unit test vs eyeballing as things are quite nuanced. You can try breaking it with valid data if you like by adding a test. Just understand this line is totally about establishing a virtual link for a remote service.. not links inside the same process.
   
   At any rate, here are a couple layers of tests that exist should you want to carry this forward.
   
   unit test: https://github.com/apache/incubator-zipkin/blob/master/zipkin/src/test/java/zipkin2/internal/DependencyLinkerTest.java
   integration test: https://github.com/apache/incubator-zipkin/blob/master/zipkin-tests/src/main/java/zipkin2/storage/ITDependencies.java
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services