You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/09/12 19:58:36 UTC

[orc] branch branch-1.5 updated: ORC-815: Build and test C++ module on CLang12

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-1.5
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/branch-1.5 by this push:
     new 086106d  ORC-815: Build and test C++ module on CLang12
086106d is described below

commit 086106d0714c12d252fe6b84cfe54ae85b18ebdd
Author: William Hyun <wi...@apache.org>
AuthorDate: Sat Jun 12 16:23:34 2021 -0700

    ORC-815: Build and test C++ module on CLang12
    
    This PR aims to build and test the C++ module on CLang12
    
    Currently, the build fails with new warnings.
    
    Manually built and tested.
    ```
    $ make test-out
    Test project /Users/william/orc/build
        Start 1: orc-test
    1/2 Test #1: orc-test .........................   Passed    3.99 sec
        Start 2: tool-test
    2/2 Test #2: tool-test ........................   Passed   11.96 sec
    
    100% tests passed, 0 tests failed out of 2
    ```
    
    Closes #718
    
    Signed-off-by: William Hyun <wi...@apache.org>
    (cherry picked from commit cb86120cf168157e4b6578972fee317c5146564c)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 97c1644..fb5879a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -86,7 +86,9 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   set (WARN_FLAGS "${WARN_FLAGS} -Wno-missing-noreturn -Wno-unknown-pragmas")
   set (WARN_FLAGS "${WARN_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
   set (WARN_FLAGS "${WARN_FLAGS} -Wconversion")
-  if (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "11.0")
+  if (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "12.0")
+    set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat -Wno-unknown-warning-option -Wno-suggest-override -Wno-suggest-destructor-override")
+  elseif (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "11.0")
     set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat")
   endif ()
   if (STOP_BUILD_ON_WARNING)