You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2009/05/17 09:50:45 UTC
[jira] Created: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Remove IComponentBorder in favor of IBehavior
---------------------------------------------
Key: WICKET-2280
URL: https://issues.apache.org/jira/browse/WICKET-2280
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-RC4
Reporter: Juergen Donnerstag
Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
before/after
and then remove it in 1.5 and maybe remote also **
public *final* Component setComponentBorder(*final* IComponentBorder border)
in component or make it
*
public
* *final* Component setComponentBorder(*final* IBehavior border)
to make it more clear to people that a border can be set by using a behavior
(else who knows..)
- Hide quoted text -
On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
juergen.donnerstag@gmail.com> wrote:
> Hi,
>
> question: looking at that code
>
> // Call implementation to render component
> final IComponentBorder border =
> getComponentBorder();
> if (border != null)
> {
> border.renderBefore(this);
> }
> notifyBehaviorsComponentBeforeRender();
> onRender(markupStream);
> notifyBehaviorsComponentRendered();
> if (border != null)
> {
> border.renderAfter(this);
> }
>
> IComponentBorder could be implemented via a behavior as well. Is there
> any reason why IComponentBorder needs this special treatment and why
> it is not implemented as a behavior?
>
> -Juergen
>
-----------------
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
i like the ComponentBorder stuff, because you can set it without
influencing any beahavior or component stuff.. just render some content
before and after a component..
i use it in debugging environment
mm:)
------
Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785201#action_12785201 ]
Igor Vaynberg commented on WICKET-2280:
---------------------------------------
no, but we can deprecate icomponentborder in 1.4.x branch....
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2280.
----------------------------------------
Resolution: Fixed
Assignee: Juergen Donnerstag
done
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785197#action_12785197 ]
Juergen Donnerstag commented on WICKET-2280:
--------------------------------------------
It'll not be backported to 1.4 since it breaks the API and existing apps. Please see the dev guidelines for the 1.4 release for more details
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-2280:
---------------------------------------
Attachment: wicket-jdo-2280-IComponentBorder.patch
attached a patch which does the deprecation
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Major Peter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785091#action_12785091 ]
Major Peter commented on WICKET-2280:
-------------------------------------
It looks like this modification didn't made it into 1.4.0 source. Shouldn't you merge this into 1.4.x branch?
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2280) Remove IComponentBorder in favor of
IBehavior
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2280:
----------------------------------
Fix Version/s: 1.5-M1
> Remove IComponentBorder in favor of IBehavior
> ---------------------------------------------
>
> Key: WICKET-2280
> URL: https://issues.apache.org/jira/browse/WICKET-2280
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-jdo-2280-IComponentBorder.patch
>
>
> Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> before/after
> and then remove it in 1.5 and maybe remote also **
> public *final* Component setComponentBorder(*final* IComponentBorder border)
> in component or make it
> *
> public
> * *final* Component setComponentBorder(*final* IBehavior border)
> to make it more clear to people that a border can be set by using a behavior
> (else who knows..)
> - Hide quoted text -
> On Sat, May 16, 2009 at 12:21, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
> > Hi,
> >
> > question: looking at that code
> >
> > // Call implementation to render component
> > final IComponentBorder border =
> > getComponentBorder();
> > if (border != null)
> > {
> > border.renderBefore(this);
> > }
> > notifyBehaviorsComponentBeforeRender();
> > onRender(markupStream);
> > notifyBehaviorsComponentRendered();
> > if (border != null)
> > {
> > border.renderAfter(this);
> > }
> >
> > IComponentBorder could be implemented via a behavior as well. Is there
> > any reason why IComponentBorder needs this special treatment and why
> > it is not implemented as a behavior?
> >
> > -Juergen
> >
> -----------------
> > Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
> > before/after
> i like the ComponentBorder stuff, because you can set it without
> influencing any beahavior or component stuff.. just render some content
> before and after a component..
> i use it in debugging environment
> mm:)
> ------
> Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.