You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2023/02/25 21:06:32 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #29769: Fix compile www assets dev
pierrejeambrun opened a new pull request, #29769:
URL: https://github.com/apache/airflow/pull/29769
`.build/www` is missing, and therefore asset compilation was not performed.
Ensure that this directory exists before redirecting the compilation output.
To reproduce:
```
rm -rf .build
breeze start-airflow --backend postgres --python 3.8 --dev-mode
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29769: Fix compile www assets dev
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29769:
URL: https://github.com/apache/airflow/pull/29769#discussion_r1117982374
##########
scripts/ci/pre_commit/pre_commit_compile_www_assets_dev.py:
##########
@@ -35,6 +35,7 @@
if __name__ == "__main__":
www_directory = AIRFLOW_SOURCES_PATH / "airflow" / "www"
+ WWW_CACHE_DIR.mkdir(exist_ok=True)
Review Comment:
```suggestion
WWW_CACHE_DIR.mkdir(exist_ok=True, parents=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun closed pull request #29769: Fix compile www assets dev
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #29769: Fix compile www assets dev
URL: https://github.com/apache/airflow/pull/29769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29769: Fix compile www assets dev
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29769:
URL: https://github.com/apache/airflow/pull/29769#discussion_r1117982459
##########
scripts/ci/pre_commit/pre_commit_compile_www_assets_dev.py:
##########
@@ -35,6 +35,7 @@
if __name__ == "__main__":
www_directory = AIRFLOW_SOURCES_PATH / "airflow" / "www"
+ WWW_CACHE_DIR.mkdir(exist_ok=True)
Review Comment:
Small nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun merged pull request #29769: Fix compile www assets dev
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #29769:
URL: https://github.com/apache/airflow/pull/29769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org