You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/01/18 17:46:27 UTC

Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8458
    https://issues.apache.org/jira/browse/MESOS-8458


Repository: mesos


Description
-------

Prior to that patch, links generated as part of the /help endpoint
response had the "/help/help/<path>" format, which is incorrect.


Diffs
-----

  3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 


Diff: https://reviews.apache.org/r/65223/diff/1/


Testing
-------

`make check` on MacOS 10.13.2


Thanks,

Alexander Rukletsov


Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Jan. 25, 2018, 2:53 a.m., Benjamin Mahler wrote:
> > Hm.. I couldn't really follow from the ticket and desription here what the impact of the bug is, are there broken links?
> > 
> > I just tested out /help on a cluster and the links are working, so is the issue something else? What am I missing? :)

This is likely due to ppor descritpion in MESOS-8458, which is now updated. I am discarding this patch since it does not actually fix the issue.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review196197
-----------------------------------------------------------


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65223/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8458
>     https://issues.apache.org/jira/browse/MESOS-8458
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to that patch, links generated as part of the /help endpoint
> response had the "/help/help/<path>" format, which is incorrect.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 
> 
> 
> Diff: https://reviews.apache.org/r/65223/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on MacOS 10.13.2
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review196197
-----------------------------------------------------------



Hm.. I couldn't really follow from the ticket and desription here what the impact of the bug is, are there broken links?

I just tested out /help on a cluster and the links are working, so is the issue something else? What am I missing? :)

- Benjamin Mahler


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65223/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8458
>     https://issues.apache.org/jira/browse/MESOS-8458
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to that patch, links generated as part of the /help endpoint
> response had the "/help/help/<path>" format, which is incorrect.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 
> 
> 
> Diff: https://reviews.apache.org/r/65223/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on MacOS 10.13.2
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review195743
-----------------------------------------------------------



PASS: Mesos patch 65223 was successfully built and tested.

Reviews applied: `['65223']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65223

- Mesos Reviewbot Windows


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65223/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8458
>     https://issues.apache.org/jira/browse/MESOS-8458
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to that patch, links generated as part of the /help endpoint
> response had the "/help/help/<path>" format, which is incorrect.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 
> 
> 
> Diff: https://reviews.apache.org/r/65223/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on MacOS 10.13.2
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>