You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/29 03:36:06 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27983: [SPARK-32105][SQL]Implement ScriptTransformation in sql/core

HyukjinKwon commented on a change in pull request #27983:
URL: https://github.com/apache/spark/pull/27983#discussion_r446753971



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala
##########
@@ -0,0 +1,400 @@
+/*

Review comment:
       @AngersZhuuuu, let's rename this file later when you actually add `ScriptTransformationExec`. If we do the renaming first in this PR and merge, I think that will keep file renaming.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org