You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/11/22 10:00:13 UTC

[jira] Created: (SLING-1878) Utiliy.filter alllows illegal JCR name characters

Utiliy.filter alllows illegal JCR name characters
-------------------------------------------------

                 Key: SLING-1878
                 URL: https://issues.apache.org/jira/browse/SLING-1878
             Project: Sling
          Issue Type: Bug
          Components: Commons
    Affects Versions: Extensions Event 2.4.2
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For: Extensions Event 3.0.0


The Utility.filter method is used to filter strings for a subset characters used for creating node names to persist events in the repository. Yet, the list of legal characters includes illegal characters like the brackets "[", "]" and the asterisk "*".

In addition the implementation is suboptimal in that it uses the String.indexOf method to check for legal characters. This can be improved by using a BitSet where the accepted characters are represented by bits turned on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-1878) Utiliy.filter alllows illegal JCR name characters

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-1878.
-----------------------------------


> Utiliy.filter alllows illegal JCR name characters
> -------------------------------------------------
>
>                 Key: SLING-1878
>                 URL: https://issues.apache.org/jira/browse/SLING-1878
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Extensions Event 2.4.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Extensions Event 3.0.0
>
>
> The Utility.filter method is used to filter strings for a subset characters used for creating node names to persist events in the repository. Yet, the list of legal characters includes illegal characters like the brackets "[", "]" and the asterisk "*".
> In addition the implementation is suboptimal in that it uses the String.indexOf method to check for legal characters. This can be improved by using a BitSet where the accepted characters are represented by bits turned on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1878) Utiliy.filter alllows illegal JCR name characters

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1878.
--------------------------------------

    Resolution: Fixed

Fixed in Rev. 1037644 (removed [, ], * and replaced String with BitSet) and added unit tests

> Utiliy.filter alllows illegal JCR name characters
> -------------------------------------------------
>
>                 Key: SLING-1878
>                 URL: https://issues.apache.org/jira/browse/SLING-1878
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>    Affects Versions: Extensions Event 2.4.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Extensions Event 3.0.0
>
>
> The Utility.filter method is used to filter strings for a subset characters used for creating node names to persist events in the repository. Yet, the list of legal characters includes illegal characters like the brackets "[", "]" and the asterisk "*".
> In addition the implementation is suboptimal in that it uses the String.indexOf method to check for legal characters. This can be improved by using a BitSet where the accepted characters are represented by bits turned on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-1878) Utiliy.filter alllows illegal JCR name characters

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler updated SLING-1878:
------------------------------------

    Component/s:     (was: Commons)
                 Extensions

> Utiliy.filter alllows illegal JCR name characters
> -------------------------------------------------
>
>                 Key: SLING-1878
>                 URL: https://issues.apache.org/jira/browse/SLING-1878
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Extensions Event 2.4.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Extensions Event 3.0.0
>
>
> The Utility.filter method is used to filter strings for a subset characters used for creating node names to persist events in the repository. Yet, the list of legal characters includes illegal characters like the brackets "[", "]" and the asterisk "*".
> In addition the implementation is suboptimal in that it uses the String.indexOf method to check for legal characters. This can be improved by using a BitSet where the accepted characters are represented by bits turned on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.