You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (JIRA)" <ji...@apache.org> on 2019/02/11 14:16:00 UTC
[jira] [Comment Edited] (CASSANDRA-15009) In-JVM Testing tooling
for paging
[ https://issues.apache.org/jira/browse/CASSANDRA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763431#comment-16763431 ]
Alex Petrov edited comment on CASSANDRA-15009 at 2/11/19 2:15 PM:
------------------------------------------------------------------
bq. were the extra commits an attempt to get that passing?
Yes, I'll commit them as a part of a different issue; sorry for the noise. I should've branched them out.
bq. I'm assuming toObjectArray is useful in other tests
I left it mostly for debugging purposes. Sometimes when you just want to println it, it might come handy.
bq. ...use compose, rather than deserialize...
Good point! I'll make a change accordingly.
Regarding test failures, they're now tackled in [CASSANDRA-15014]. I've separated commits.
I've also modified the 3.0, 3.11 and trunk patches a bit to make sure that distributed queries are covered. Previous patch was calling {{executeInternal}} under the hood, which is not the right execution path.
was (Author: ifesdjeen):
bq. were the extra commits an attempt to get that passing?
Yes, I'll commit them as a part of a different issue; sorry for the noise. I should've branched them out.
bq. I'm assuming toObjectArray is useful in other tests
I left it mostly for debugging purposes. Sometimes when you just want to println it, it might come handy.
bq. ...use compose, rather than deserialize...
Good point! I'll make a change accordingly.
> In-JVM Testing tooling for paging
> ---------------------------------
>
> Key: CASSANDRA-15009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15009
> Project: Cassandra
> Issue Type: Test
> Reporter: Alex Petrov
> Assignee: Jon Meredith
> Priority: Major
>
> Add distributed pager to in-jvm distributed tests to allow realistic pager tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org