You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/12 07:35:08 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #11234: perf: cache dashboard bootstrap data
ktmud opened a new pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234
### SUMMARY
Large and complex dashboards can be very slow to load because they need to read all the slices and datasources related and they all have go through SQL queries without caching.
A previous [attempt](https://github.com/apache/incubator-superset/pull/10963) to cache the rendered dashboard page had to be reverted because it did not consider user-specific data on that page. Why don't we cache the non-user-specific bootstrap data instead?
This PR extracts the data building logics from the `/dashboard/:id_or_slug` Flask view to the `Dashboard` model and uses Flack caching decorator to manage the cache. Cache will be cleaned up when either of the dashboard, the associated slices or datasources are updated.
When tested on a dashboard with 300+ slices, this change can save more than 3 seconds of page load time.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Make sure the dashboard page still work as expected.
- You second visit to a very large dashboard page should be much more faster
- Update a slice or datasource, refresh the Dashboard page, you should see the updates
- User access etc should still work
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #10963 #11137 #11203
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.49%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.90% -0.50%
==========================================
Files 832 831 -1
Lines 39390 39451 +61
Branches 3592 3592
==========================================
- Hits 24184 24027 -157
- Misses 15025 15243 +218
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.01% <65.21%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `81.03% <53.62%> (-7.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.57% <61.11%> (-0.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...ee36591](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `10.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
===========================================
- Coverage 65.52% 55.24% -10.29%
===========================================
Files 831 404 -427
Lines 39295 13405 -25890
Branches 3592 3390 -202
===========================================
- Hits 25747 7405 -18342
+ Misses 13439 5810 -7629
- Partials 109 190 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <ø> (-0.65%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [645 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...d5a7959](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.27% -0.12%
==========================================
Files 832 831 -1
Lines 39390 39454 +64
Branches 3592 3592
==========================================
- Hits 24184 24176 -8
- Misses 15025 15097 +72
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.60% <65.51%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r504205786
##########
File path: superset/models/dashboard.py
##########
@@ -240,6 +251,29 @@ def data(self) -> Dict[str, Any]:
"last_modified_time": self.changed_on.replace(microsecond=0).timestamp(),
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(self) -> Dict[str, Any]:
+ """Bootstrap data for rendering the dashboard page."""
+ slices = self.slices
+ datasource_slices = utils.indexed(slices, "datasource")
+ return {
Review comment:
does any of this metadata rely on checking user access to the datasources? Double checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `3.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 62.40% -3.16%
==========================================
Files 832 438 -394
Lines 39393 14681 -24712
Branches 3592 3592
==========================================
- Hits 25828 9162 -16666
+ Misses 13456 5338 -8118
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [549 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **increase** coverage by `1.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.50% 62.62% +1.12%
==========================================
Files 832 438 -394
Lines 39404 14681 -24723
Branches 3593 3593
==========================================
- Hits 24234 9194 -15040
+ Misses 14989 5306 -9683
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | | |
| [superset/databases/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | | |
| [...tions/versions/3b626e2a6783\_sync\_db\_with\_models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zYjYyNmUyYTY3ODNfc3luY19kYl93aXRoX21vZGVscy5weQ==) | | |
| [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | | |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | | |
| [...ations/versions/2e5a0ee25ed4\_refractor\_alerting.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yZTVhMGVlMjVlZDRfcmVmcmFjdG9yX2FsZXJ0aW5nLnB5) | | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | | |
| [...t/migrations/versions/ca69c70ec99b\_tracking\_url.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jYTY5YzcwZWM5OWJfdHJhY2tpbmdfdXJsLnB5) | | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | | |
| ... and [374 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503094641
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
Cache dashboard page for 2 weeks by default, assuming a typical "shelf time" for a new dashboard.
##########
File path: superset/connectors/base/models.py
##########
@@ -477,6 +477,10 @@ def update_from_object(self, obj: Dict[str, Any]) -> None:
if self.column_class and "columns" in obj
else []
)
+ if is_feature_enabled("DASHBOARD_CACHE"):
+ from superset.models.dashboard import Dashboard
+
+ Dashboard.clear_cache_for_datasource(datasource_id=self.id)
Review comment:
Tried to add this to SQLAlchemy events, just like what we did with slices, but it was somehow triggered multiple times (4 or 5), which could have performance risks when a datasource is used in multiple dashboards.
So I moved it to this `BaseDatasource` API instead. The drawback is it may not trigger if the datasource is updated from FAB CRUD view (an unlikely use case).
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
@etr2460 @villebro This feature (`REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD`) has been [default on](https://github.com/apache/incubator-superset/pull/9585) for about 6 months now. Should we clean it up?
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
+ ) -> Dict[str, Any]:
+ """Bootstrap data for rendering the dashboard page."""
+ slices = self.slices
+ datasource_slices = defaultdict(list)
+ for slc in slices:
+ datasource = slc.datasource
+ if datasource:
+ datasource_slices[datasource].append(slc)
+
+ data = {
+ # dashboard metadata
+ "dashboard": self.data,
+ # slices data
+ "slices": [slc.data for slc in slices],
+ # datasource data
+ "datasources": {
+ # Filter out unneeded fields from the datasource payload
+ datasource.uid: datasource.data_for_slices(slices)
+ if reduce_payload
Review comment:
TODO: clean up when `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` is cleaned up.
##########
File path: superset/models/dashboard.py
##########
@@ -145,7 +154,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return self.dashboard_title or str(self.id)
+ return f"Dashboard<{self.slug or self.id}>"
Review comment:
`__repr__` is used in cache key.
##########
File path: superset/models/dashboard.py
##########
@@ -131,7 +140,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
css = Column(Text)
json_metadata = Column(Text)
slug = Column(String(255), unique=True)
- slices = relationship("Slice", secondary=dashboard_slices, backref="dashboards")
+ slices = relationship(Slice, secondary=dashboard_slices, backref="dashboards")
Review comment:
Remove quotes for consistency.
##########
File path: tests/superset_test_config.py
##########
@@ -50,6 +50,7 @@
SQL_MAX_ROW = 666
SQLLAB_CTAS_NO_LIMIT = True # SQL_MAX_ROW will not take affect for the CTA queries
FEATURE_FLAGS = {
+ **FEATURE_FLAGS,
Review comment:
So we can override the configs from `~/.superset/config.py`
##########
File path: superset/dashboards/dao.py
##########
@@ -108,7 +108,7 @@ def set_dash_metadata(
and obj["meta"]["chartId"]
):
chart_id = obj["meta"]["chartId"]
- obj["meta"]["uuid"] = uuid_map[chart_id]
+ obj["meta"]["uuid"] = uuid_map.get(chart_id)
Review comment:
This will throw 500 errors when chart don't have uuid, which could happen when chart is deleted but the dashboard cache is not purged for some reason.
##########
File path: superset/charts/commands/delete.py
##########
@@ -44,6 +45,7 @@ def __init__(self, user: User, model_id: int):
def run(self) -> Model:
self.validate()
try:
+ Dashboard.clear_cache_for_slice(slice_id=self._model_id)
Review comment:
Can't use `before_delete` event for `Slice` because the association record in the relationship table `datasource_slice` is deleted before the `Slice` object is deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503484317
##########
File path: superset/connectors/druid/__init__.py
##########
@@ -14,4 +14,3 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from . import models, views
Review comment:
Cleaned up to break circular imports, because I want to import `DruidMetric` and `DruidColumn` from `dashboard.py`.
##########
File path: superset/models/dashboard.py
##########
@@ -488,21 +566,46 @@ def export_dashboards( # pylint: disable=too-many-locals
)
-def event_after_dashboard_changed(
- _mapper: Mapper, _connection: Connection, target: Dashboard
-) -> None:
- url = get_url_path("Superset.dashboard", dashboard_id_or_slug=target.id)
- cache_dashboard_thumbnail.delay(url, target.digest, force=True)
-
+OnDashboardChange = Callable[[Mapper, Connection, Dashboard], Any]
# events for updating tags
if is_feature_enabled("TAGGING_SYSTEM"):
sqla.event.listen(Dashboard, "after_insert", DashboardUpdater.after_insert)
sqla.event.listen(Dashboard, "after_update", DashboardUpdater.after_update)
sqla.event.listen(Dashboard, "after_delete", DashboardUpdater.after_delete)
-
-# events for updating tags
if is_feature_enabled("THUMBNAILS_SQLA_LISTENERS"):
- sqla.event.listen(Dashboard, "after_insert", event_after_dashboard_changed)
- sqla.event.listen(Dashboard, "after_update", event_after_dashboard_changed)
+ update_thumbnail: OnDashboardChange = lambda _, __, target: target.update_thumbnail()
+ sqla.event.listen(Dashboard, "after_insert", update_thumbnail)
+ sqla.event.listen(Dashboard, "after_update", update_thumbnail)
Review comment:
Did some refactor for consistency.
##########
File path: superset/models/core.py
##########
@@ -719,8 +718,5 @@ class FavStar(Model): # pylint: disable=too-few-public-methods
# events for updating tags
if is_feature_enabled("TAGGING_SYSTEM"):
- sqla.event.listen(Dashboard, "after_insert", DashboardUpdater.after_insert)
- sqla.event.listen(Dashboard, "after_update", DashboardUpdater.after_update)
- sqla.event.listen(Dashboard, "after_delete", DashboardUpdater.after_delete)
Review comment:
I think this is a duplicate of https://github.com/apache/incubator-superset/blob/93fdf1d64465b3378de65fb1b058e1a04742a70f/superset/models/dashboard.py#L573
cc @suddjian
Removed so that it's possible to import `models.core` from `dashboard.py`. It makes more sense to let `Dashboard` depends on `core` (if needed) than vice versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 65.36% -0.16%
==========================================
Files 831 831
Lines 39295 39338 +43
Branches 3592 3592
==========================================
- Hits 25747 25714 -33
- Misses 13439 13511 +72
- Partials 109 113 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <ø> (-0.65%)` | :arrow_down: |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.69% <62.90%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.97% <0.00%> (-5.20%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.39% -0.01%
==========================================
Files 832 831 -1
Lines 39390 39454 +64
Branches 3592 3592
==========================================
+ Hits 24184 24222 +38
- Misses 15025 15051 +26
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.51%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.18%`.
> The diff coverage is `67.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.33% -4.19%
==========================================
Files 831 831
Lines 39295 39331 +36
Branches 3592 3592
==========================================
- Hits 25747 24125 -1622
- Misses 13439 15025 +1586
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.70% <67.27%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `88.85% <50.00%> (-0.59%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `86.03% <67.50%> (-2.00%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16f7b2b5257fac9fe1d67a1ab6ff946c2b9a427f?el=desc) will **decrease** coverage by `2.64%`.
> The diff coverage is `66.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.47% 58.82% -2.65%
==========================================
Files 832 797 -35
Lines 39445 38232 -1213
Branches 3598 3396 -202
==========================================
- Hits 24248 22491 -1757
- Misses 15015 15551 +536
- Partials 182 190 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.29% <ø> (?)` | |
| #javascript | `?` | |
| #python | `60.73% <66.08%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <100.00%> (+10.82%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [342 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [16f7b2b...985fdb0](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503534639
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I just feel one day is too short. Normally when a new dashboard is published and PSA sent, users may still trickle in after one or two weeks.
Since this cache is actively purged when things are updating, it's OK to set a longer expiration time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.61%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.90% -4.62%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 23958 -1789
- Misses 13439 15196 +1757
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.01% <62.90%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.39% -0.01%
==========================================
Files 832 831 -1
Lines 39390 39453 +63
Branches 3592 3592
==========================================
+ Hits 24184 24221 +37
- Misses 15025 15051 +26
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.21%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 65.50% -0.02%
==========================================
Files 831 831
Lines 39295 39338 +43
Branches 3592 3592
==========================================
+ Hits 25747 25770 +23
- Misses 13439 13459 +20
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.89% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.69% <62.90%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.64%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.47% <0.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `95.34% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503521410
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I didn't see any typical pattern for dashboard updates.
Why do we need this cache_timeout for dashboard? Anyway Dashboard will clear cache when certain events happens right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r504207034
##########
File path: tests/superset_test_config.py
##########
@@ -50,6 +50,7 @@
SQL_MAX_ROW = 666
SQLLAB_CTAS_NO_LIMIT = True # SQL_MAX_ROW will not take affect for the CTA queries
FEATURE_FLAGS = {
+ **FEATURE_FLAGS,
Review comment:
Does this do anything? `FEATURE_FLAGS` is empty by default in the config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.30%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.21% -4.31%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 24080 -1667
- Misses 13439 15074 +1635
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.50% <62.90%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503590295
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
https://github.com/apache/incubator-superset/pull/11244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.30%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.21% -4.31%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 24079 -1668
- Misses 13439 15075 +1636
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.50% <62.90%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.50% 61.39% -0.12%
==========================================
Files 832 831 -1
Lines 39404 39467 +63
Branches 3593 3593
==========================================
- Hits 24234 24229 -5
- Misses 14989 15057 +68
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.65% <65.21%> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-7.78%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.58%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 60.97% -4.59%
==========================================
Files 832 831 -1
Lines 39393 39438 +45
Branches 3592 3592
==========================================
- Hits 25828 24049 -1779
- Misses 13456 15208 +1752
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.13% <70.79%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <ø> (-0.13%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <80.95%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `5.59%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 59.92% -5.60%
==========================================
Files 831 393 -438
Lines 39295 24643 -14652
Branches 3592 0 -3592
==========================================
- Hits 25747 14767 -10980
+ Misses 13439 9876 -3563
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.92% <62.90%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503120817
##########
File path: tests/superset_test_config.py
##########
@@ -50,6 +50,7 @@
SQL_MAX_ROW = 666
SQLLAB_CTAS_NO_LIMIT = True # SQL_MAX_ROW will not take affect for the CTA queries
FEATURE_FLAGS = {
+ **FEATURE_FLAGS,
Review comment:
So we can override the configs from `SUPERSET_CONFIG_PATH` (I've set it to `~/.superset/config.py`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.50% 61.49% -0.01%
==========================================
Files 832 831 -1
Lines 39404 39467 +63
Branches 3593 3593
==========================================
+ Hits 24234 24271 +37
- Misses 14989 15015 +26
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.82% <65.21%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `67.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 60.61% -4.95%
==========================================
Files 832 393 -439
Lines 39393 24768 -14625
Branches 3592 0 -3592
==========================================
- Hits 25828 15014 -10814
+ Misses 13456 9754 -3702
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.61% <67.88%> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <ø> (+0.42%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <64.70%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.01%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 65.40% +4.01%
==========================================
Files 832 831 -1
Lines 39390 39456 +66
Branches 3592 3592
==========================================
+ Hits 24184 25807 +1623
+ Misses 15025 13536 -1489
+ Partials 181 113 -68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (?)` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.21%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.30%`.
> The diff coverage is `67.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.22% -4.31%
==========================================
Files 831 831
Lines 39295 39331 +36
Branches 3592 3592
==========================================
- Hits 25747 24079 -1668
- Misses 13439 15071 +1632
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.51% <67.27%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `88.85% <50.00%> (-0.59%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `86.03% <67.50%> (-2.00%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503600592
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.16%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 61.39% -4.17%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24221 -1607
- Misses 13456 15047 +1591
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.80% <70.79%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <ø> (+0.70%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <80.95%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **decrease** coverage by `0.49%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.50% 61.00% -0.50%
==========================================
Files 832 831 -1
Lines 39404 39465 +61
Branches 3593 3593
==========================================
- Hits 24234 24077 -157
- Misses 14989 15207 +218
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.05% <65.21%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.02% <61.11%> (-0.78%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `9.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 55.88% -9.64%
==========================================
Files 831 404 -427
Lines 39295 13405 -25890
Branches 3592 3390 -202
==========================================
- Hits 25747 7492 -18255
+ Misses 13439 5731 -7708
- Partials 109 182 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.88% <ø> (ø)` | |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [643 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...d5a7959](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16f7b2b5257fac9fe1d67a1ab6ff946c2b9a427f?el=desc) will **decrease** coverage by `2.41%`.
> The diff coverage is `66.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.47% 59.05% -2.42%
==========================================
Files 832 797 -35
Lines 39445 38232 -1213
Branches 3598 3396 -202
==========================================
- Hits 24248 22579 -1669
- Misses 15015 15471 +456
Partials 182 182
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.94% <ø> (?)` | |
| #javascript | `?` | |
| #python | `60.73% <66.08%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <100.00%> (+10.82%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [343 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [16f7b2b...985fdb0](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503535744
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
eek, i forgot to clean it up... yes, we should.
do you want me to do that in a PR prior to this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.26% -0.14%
==========================================
Files 832 831 -1
Lines 39390 39442 +52
Branches 3592 3592
==========================================
- Hits 24184 24163 -21
- Misses 15025 15098 +73
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.58% <65.21%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **increase** coverage by `4.12%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.50% 65.62% +4.12%
==========================================
Files 832 831 -1
Lines 39404 39470 +66
Branches 3593 3593
==========================================
+ Hits 24234 25904 +1670
+ Misses 14989 13457 -1532
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.95% <ø> (?)` | |
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.84% <65.21%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r504236643
##########
File path: superset/models/dashboard.py
##########
@@ -240,6 +251,29 @@ def data(self) -> Dict[str, Any]:
"last_modified_time": self.changed_on.replace(microsecond=0).timestamp(),
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(self) -> Dict[str, Any]:
+ """Bootstrap data for rendering the dashboard page."""
+ slices = self.slices
+ datasource_slices = utils.indexed(slices, "datasource")
+ return {
Review comment:
No it doesn't. All metadata is returned. Access checking is done in the [view](https://github.com/apache/incubator-superset/blob/19c63954a8432b8d0c049d02c4b8dae6764478f7/superset/views/core.py#L1622).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16f7b2b5257fac9fe1d67a1ab6ff946c2b9a427f?el=desc) will **decrease** coverage by `1.43%`.
> The diff coverage is `66.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.47% 60.04% -1.44%
==========================================
Files 832 393 -439
Lines 39445 24820 -14625
Branches 3598 0 -3598
==========================================
- Hits 24248 14902 -9346
+ Misses 15015 9918 -5097
+ Partials 182 0 -182
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.04% <66.08%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <100.00%> (+10.82%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [16f7b2b...985fdb0](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.19%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.33% -4.20%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 24125 -1622
- Misses 13439 15029 +1590
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.69% <62.90%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.96% -0.43%
==========================================
Files 832 831 -1
Lines 39390 39453 +63
Branches 3592 3592
==========================================
- Hits 24184 24054 -130
- Misses 15025 15218 +193
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.11% <65.21%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `81.03% <53.62%> (-7.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...ee36591](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.93% -0.47%
==========================================
Files 832 831 -1
Lines 39390 39453 +63
Branches 3592 3592
==========================================
- Hits 24184 24041 -143
- Misses 15025 15231 +206
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.06% <65.21%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `81.03% <53.62%> (-7.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.57% <61.11%> (-0.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...ee36591](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.82%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 60.73% -4.83%
==========================================
Files 832 831 -1
Lines 39393 39438 +45
Branches 3592 3592
==========================================
- Hits 25828 23954 -1874
- Misses 13456 15303 +1847
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.74% <70.79%> (-1.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.31% <ø> (-2.09%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.57% <80.95%> (-0.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [201 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
=======================================
Coverage 61.50% 61.50%
=======================================
Files 832 831 -1
Lines 39404 39467 +63
Branches 3593 3593
=======================================
+ Hits 24234 24274 +40
- Misses 14989 15012 +23
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.84% <65.21%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.07% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16f7b2b5257fac9fe1d67a1ab6ff946c2b9a427f?el=desc) will **decrease** coverage by `0.73%`.
> The diff coverage is `66.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.47% 60.73% -0.74%
==========================================
Files 832 393 -439
Lines 39445 24820 -14625
Branches 3598 0 -3598
==========================================
- Hits 24248 15075 -9173
+ Misses 15015 9745 -5270
+ Partials 182 0 -182
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.73% <66.08%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <100.00%> (+10.82%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [16f7b2b...985fdb0](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.96% -0.43%
==========================================
Files 832 831 -1
Lines 39390 39454 +64
Branches 3592 3592
==========================================
- Hits 24184 24055 -129
- Misses 15025 15218 +193
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.11% <65.51%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.15%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 65.55% +4.15%
==========================================
Files 832 831 -1
Lines 39390 39457 +67
Branches 3592 3592
==========================================
+ Hits 24184 25866 +1682
+ Misses 15025 13482 -1543
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.88% <ø> (?)` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.51%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.59%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 60.97% -4.60%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24054 -1774
- Misses 13456 15214 +1758
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.12% <70.79%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <ø> (-0.13%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <80.95%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503554297
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
Either way works. But it sure will make this PR cleaner if it's merged before this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.33%`.
> The diff coverage is `67.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.19% -4.34%
==========================================
Files 831 831
Lines 39295 39331 +36
Branches 3592 3592
==========================================
- Hits 25747 24067 -1680
- Misses 13439 15083 +1644
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.46% <67.27%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `88.85% <50.00%> (-0.59%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `86.03% <67.50%> (-2.00%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503536020
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I think Grace's point is to give this an infinite timeout, since it'll be purged. i agree with that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **increase** coverage by `3.97%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.50% 65.48% +3.97%
==========================================
Files 832 831 -1
Lines 39404 39470 +66
Branches 3593 3593
==========================================
+ Hits 24234 25845 +1611
+ Misses 14989 13512 -1477
+ Partials 181 113 -68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.27% <ø> (?)` | |
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.84% <65.21%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503534639
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I just feel one day (the default) is too short. Normally when a new dashboard is published and PSA sent, visitors may still trickle in after one or two weeks.
Since this cache is actively purged when things are updating, it's OK to set a longer expiration time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.95%`.
> The diff coverage is `67.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 60.61% -4.96%
==========================================
Files 832 393 -439
Lines 39393 24768 -14625
Branches 3592 0 -3592
==========================================
- Hits 25828 15013 -10815
+ Misses 13456 9755 -3701
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.61% <67.88%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <ø> (+0.42%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <64.70%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6cf698cc6a8150017eab8b5ea3c43eb1d046dd5f?el=desc) will **decrease** coverage by `10.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
===========================================
- Coverage 65.45% 55.24% -10.22%
===========================================
Files 832 404 -428
Lines 39394 13405 -25989
Branches 3592 3390 -202
===========================================
- Hits 25786 7405 -18381
+ Misses 13495 5810 -7685
- Partials 113 190 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <ø> (-0.19%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [639 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6cf698c...d68bf10](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16f7b2b5257fac9fe1d67a1ab6ff946c2b9a427f?el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `66.08%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.47% 60.53% -0.94%
==========================================
Files 832 393 -439
Lines 39445 24820 -14625
Branches 3598 0 -3598
==========================================
- Hits 24248 15026 -9222
+ Misses 15015 9794 -5221
+ Partials 182 0 -182
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.53% <66.08%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <100.00%> (+10.82%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [16f7b2b...985fdb0](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r504233953
##########
File path: tests/superset_test_config.py
##########
@@ -50,6 +50,7 @@
SQL_MAX_ROW = 666
SQLLAB_CTAS_NO_LIMIT = True # SQL_MAX_ROW will not take affect for the CTA queries
FEATURE_FLAGS = {
+ **FEATURE_FLAGS,
Review comment:
But `SUPERSET_CONFIG_PATH` (a config file) is loaded before `SUPERSET_CONFIG` (a Python module). This allows users to override the feature flags in `SUPERSET_CONFIG_PATH` (a file not tracked in Git) when starting superset like this:
```
SUPERSET_CONFIG=tests.superset_test_config flask run -p 8088 --no-debugger
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 62.40% +1.01%
==========================================
Files 832 438 -394
Lines 39390 14681 -24709
Branches 3592 3592
==========================================
- Hits 24184 9162 -15022
+ Misses 15025 5338 -9687
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY3NzX3RlbXBsYXRlcy5weQ==) | | |
| [...s/versions/eca4694defa7\_sqllab\_setting\_defaults.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lY2E0Njk0ZGVmYTdfc3FsbGFiX3NldHRpbmdfZGVmYXVsdHMucHk=) | | |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
| [superset/models/user\_attributes.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3VzZXJfYXR0cmlidXRlcy5weQ==) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| [...d7c1a0d6f2da\_remove\_limit\_used\_from\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kN2MxYTBkNmYyZGFfcmVtb3ZlX2xpbWl0X3VzZWRfZnJvbV9xdWVyeV9tb2RlbC5weQ==) | | |
| [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | | |
| [superset/cachekeys/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2FjaGVrZXlzL3NjaGVtYXMucHk=) | | |
| ... and [374 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-708063097
> could we add unit tests for the new decorators?
https://github.com/apache/incubator-superset/pull/11234/commits/7939b0a73c88cade300b288cb8a1106cca85aacc
Added some basic tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6cf698cc6a8150017eab8b5ea3c43eb1d046dd5f?el=desc) will **decrease** coverage by `9.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.59% 55.89% -9.71%
==========================================
Files 832 404 -428
Lines 39394 13405 -25989
Branches 3592 3390 -202
==========================================
- Hits 25842 7493 -18349
+ Misses 13443 5730 -7713
- Partials 109 182 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.89% <ø> (-0.19%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [639 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6cf698c...d68bf10](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.29%`.
> The diff coverage is `67.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.22% -4.30%
==========================================
Files 831 831
Lines 39295 39331 +36
Branches 3592 3592
==========================================
- Hits 25747 24080 -1667
- Misses 13439 15070 +1631
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.51% <67.27%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `88.85% <50.00%> (-0.59%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `86.03% <67.50%> (-2.00%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.15%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 65.54% +4.15%
==========================================
Files 832 831 -1
Lines 39390 39456 +66
Branches 3592 3592
==========================================
+ Hits 24184 25863 +1679
+ Misses 15025 13484 -1541
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.87% <ø> (?)` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.21%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.84%`.
> The diff coverage is `67.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.67% -4.85%
==========================================
Files 831 831
Lines 39295 39320 +25
Branches 3592 3592
==========================================
- Hits 25747 23858 -1889
- Misses 13439 15281 +1842
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.64% <67.27%> (-1.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `88.85% <50.00%> (-0.59%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `86.03% <67.50%> (-2.00%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [201 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.68%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.84% -4.69%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 23932 -1815
- Misses 13439 15222 +1783
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.90% <62.90%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `4.01%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 65.41% +4.01%
==========================================
Files 832 831 -1
Lines 39390 39457 +67
Branches 3592 3592
==========================================
+ Hits 24184 25810 +1626
+ Misses 15025 13534 -1491
+ Partials 181 113 -68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.23% <ø> (?)` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.51%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.67%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.85% -4.68%
==========================================
Files 831 831
Lines 39295 39324 +29
Branches 3592 3592
==========================================
- Hits 25747 23929 -1818
- Misses 13439 15214 +1775
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.92% <62.90%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [191 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `9.75%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 55.80% -9.76%
==========================================
Files 832 404 -428
Lines 39393 13405 -25988
Branches 3592 3390 -202
==========================================
- Hits 25828 7481 -18347
+ Misses 13456 5742 -7714
- Partials 109 182 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.80% <ø> (-0.09%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [640 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...2b795cd](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.28%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 61.28% -4.29%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24176 -1652
- Misses 13456 15092 +1636
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.61% <70.79%> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <ø> (+0.42%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <80.95%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.19%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 61.33% -4.20%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 24125 -1622
- Misses 13439 15029 +1590
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.69% <62.90%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.93% -0.46%
==========================================
Files 832 831 -1
Lines 39390 39454 +64
Branches 3592 3592
==========================================
- Hits 24184 24042 -142
- Misses 15025 15231 +206
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.06% <65.51%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.57% <61.11%> (-0.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r504233953
##########
File path: tests/superset_test_config.py
##########
@@ -50,6 +50,7 @@
SQL_MAX_ROW = 666
SQLLAB_CTAS_NO_LIMIT = True # SQL_MAX_ROW will not take affect for the CTA queries
FEATURE_FLAGS = {
+ **FEATURE_FLAGS,
Review comment:
But `SUPERSET_CONFIG_PATH` (a config file) is loaded before `SUPERSET_CONFIG` (a Python module). This allows users to override the feature flags in `SUPERSET_CONFIG_PATH` (a file not tracked in Git) when starting superset like this:
```
SUPERSET_CONFIG=tests.superset_test_config superset run
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.17%`.
> The diff coverage is `67.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 61.39% -4.18%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24218 -1610
- Misses 13456 15050 +1594
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.78% <67.88%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <ø> (+0.70%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <64.70%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503583056
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I checked the data and there indeed are some popular dashboards that haven't been updated for almost half a year. I'll set the expiration date to 1 year.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `5.61%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 59.90% -5.62%
==========================================
Files 831 393 -438
Lines 39295 24652 -14643
Branches 3592 0 -3592
==========================================
- Hits 25747 14769 -10978
+ Misses 13439 9883 -3556
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.90% <62.90%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.64%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.87% -4.65%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 23945 -1802
- Misses 13439 15209 +1770
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.96% <62.90%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <50.00%> (-0.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `5.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 56.10% -5.30%
==========================================
Files 832 404 -428
Lines 39390 13405 -25985
Branches 3592 3390 -202
==========================================
- Hits 24184 7521 -16663
+ Misses 15025 5702 -9323
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.10% <ø> (?)` | |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [715 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...4ba6fc2](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503587460
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool = is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
let me try to get the cleanup pr out tonight
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.28%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 61.28% -4.29%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24175 -1653
- Misses 13456 15093 +1637
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.61% <70.79%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <ø> (+0.42%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <80.95%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `65.51%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 60.93% -0.46%
==========================================
Files 832 831 -1
Lines 39390 39454 +64
Branches 3592 3592
==========================================
- Hits 24184 24042 -142
- Misses 15025 15231 +206
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.06% <65.51%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.70% <50.00%> (-7.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.57% <61.11%> (-0.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...4ba6fc2](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `5.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 56.11% -5.29%
==========================================
Files 832 404 -428
Lines 39390 13405 -25985
Branches 3592 3390 -202
==========================================
- Hits 24184 7522 -16662
+ Misses 15025 5701 -9324
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.11% <ø> (?)` | |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMudHN4) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [715 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...4ba6fc2](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.39% -0.01%
==========================================
Files 832 831 -1
Lines 39390 39453 +63
Branches 3592 3592
==========================================
+ Hits 24184 24221 +37
- Misses 15025 15051 +26
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.79% <65.21%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <100.00%> (+0.70%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **increase** coverage by `1.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
+ Coverage 61.39% 62.40% +1.01%
==========================================
Files 832 438 -394
Lines 39390 14681 -24709
Branches 3592 3592
==========================================
- Hits 24184 9162 -15022
+ Misses 15025 5338 -9687
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
| [...rations/versions/e46f2d27a08e\_materialize\_perms.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNDZmMmQyN2EwOGVfbWF0ZXJpYWxpemVfcGVybXMucHk=) | | |
| [superset/datasets/commands/refresh.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvcmVmcmVzaC5weQ==) | | |
| [superset/views/redirects.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | |
| [...ons/versions/e96dbf2cfef0\_datasource\_cluster\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOTZkYmYyY2ZlZjBfZGF0YXNvdXJjZV9jbHVzdGVyX2ZrLnB5) | | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | | |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | | |
| [superset/migrations/env.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | | |
| ... and [375 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...ee36591](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `5.55%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 59.96% -5.56%
==========================================
Files 831 393 -438
Lines 39295 24654 -14641
Branches 3592 0 -3592
==========================================
- Hits 25747 14784 -10963
+ Misses 13439 9870 -3569
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.96% <62.90%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `10.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
===========================================
- Coverage 65.56% 55.15% -10.42%
===========================================
Files 832 404 -428
Lines 39393 13405 -25988
Branches 3592 3390 -202
===========================================
- Hits 25828 7393 -18435
+ Misses 13456 5822 -7634
- Partials 109 190 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.15% <ø> (-0.74%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `3.57% <0.00%> (-93.73%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [642 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...2b795cd](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `3.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 62.40% -3.12%
==========================================
Files 831 438 -393
Lines 39295 14681 -24614
Branches 3592 3592
==========================================
- Hits 25747 9162 -16585
+ Misses 13439 5338 -8101
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...34e2093](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcdf15f4d73b9b3b1b96a9b92deec7ba9c67108f?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.39% 61.27% -0.12%
==========================================
Files 832 831 -1
Lines 39390 39453 +63
Branches 3592 3592
==========================================
- Hits 24184 24176 -8
- Misses 15025 15096 +71
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.60% <65.21%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <61.11%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <100.00%> (+0.42%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.59% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [dcdf15f...1183dde](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.64%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.87% -4.65%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 23946 -1801
- Misses 13439 15208 +1769
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `59.96% <62.90%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503521410
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I didn't see any typical pattern for dashboard updates.
Why do we need this cache_timeout for dashboard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503536433
##########
File path: superset/views/core.py
##########
@@ -1040,7 +1038,7 @@ def copy_dash( # pylint: disable=no-self-use
for value in data["positions"].values():
if isinstance(value, dict) and value.get("meta", {}).get("chartId"):
old_id = value["meta"]["chartId"]
- new_id = old_to_new_slice_ids[old_id]
+ new_id = old_to_new_slice_ids.get(old_id)
Review comment:
This fixes a 500 error when duplicating a dashboard with deleted slices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **decrease** coverage by `0.41%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.50% 61.08% -0.42%
==========================================
Files 832 831 -1
Lines 39404 39467 +63
Branches 3593 3593
==========================================
- Hits 24234 24107 -127
- Misses 14989 15179 +190
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.16% <65.21%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.51% <61.11%> (-0.29%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.26% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e58730092f7ea80ae3b7e29aaa7074b137d3572?el=desc) will **decrease** coverage by `4.28%`.
> The diff coverage is `67.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.56% 61.28% -4.29%
==========================================
Files 832 831 -1
Lines 39393 39449 +56
Branches 3592 3592
==========================================
- Hits 25828 24176 -1652
- Misses 13456 15092 +1636
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.61% <67.88%> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.82% <ø> (+0.42%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `82.10% <56.25%> (-5.93%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.81% <64.70%> (-0.30%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [8e58730...93fdf1d](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#discussion_r503521410
##########
File path: superset/config.py
##########
@@ -369,6 +370,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
CACHE_DEFAULT_TIMEOUT = 60 * 60 * 24
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
TABLE_NAMES_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
+DASHBOARD_CACHE_TIMEOUT = 60 * 60 * 24 * 14
Review comment:
I do not like this assumption. I didn't see any typical pattern for dashboard updates.
Why do we need this cache_timeout for dashboard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d8541e3b635ef00afbbf9ec0d0952778f9b99af?el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `65.21%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.50% 61.04% -0.47%
==========================================
Files 832 831 -1
Lines 39404 39467 +63
Branches 3593 3593
==========================================
- Hits 24234 24091 -143
- Misses 14989 15195 +206
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.62% <ø> (ø)` | |
| #python | `60.10% <65.21%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <49.20%> (-7.41%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.02% <61.11%> (-0.78%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `64.55% <95.00%> (+9.55%)` | :arrow_up: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.43% <100.00%> (-0.97%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.73% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `70.58% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [6d8541e...19c6395](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11234: perf: cache dashboard bootstrap data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11234:
URL: https://github.com/apache/incubator-superset/pull/11234#issuecomment-706955486
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=h1) Report
> Merging [#11234](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/513bf10a38e10f5dc69f1a93fe28478df4f0b32d?el=desc) will **decrease** coverage by `4.61%`.
> The diff coverage is `62.90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 65.52% 60.90% -4.62%
==========================================
Files 831 831
Lines 39295 39335 +40
Branches 3592 3592
==========================================
- Hits 25747 23958 -1789
- Misses 13439 15196 +1757
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (ø)` | |
| #python | `60.01% <62.90%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.88% <50.00%> (-0.33%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `84.19% <60.78%> (-3.85%)` | :arrow_down: |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `91.42% <100.00%> (+0.51%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=footer). Last update [513bf10...a18c4cf](https://codecov.io/gh/apache/incubator-superset/pull/11234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org