[GitHub] [beam] y1chi commented on a change in pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk

[GitBox <gi...@apache.org>]

y1chi commented on a change in pull request #12013:
URL: https://github.com/apache/beam/pull/12013#discussion_r440466258



##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -819,7 +819,7 @@ def __init__(self,
     # There is no guarantee that the runner only set
     # timer_api_service_descriptor when having timers. So this field cannot be
     # used as an indicator of timers.
-    if self.process_bundle_descriptor.timer_api_service_descriptor:
+    if self.process_bundle_descriptor.timer_api_service_descriptor.url:

Review comment:
       I believe for proto3 all fields are optional and have a default instance thus can't be None.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org