You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/05 20:14:40 UTC
Review Request 33854: Fix RC verification script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/
-----------------------------------------------------------
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
Script has drifted over time, this makes it functional again.
Diffs
-----
build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
Diff: https://reviews.apache.org/r/33854/diff/
Testing
-------
Ran it and verified 0.8.0.
Thanks,
Bill Farner
Re: Review Request 33854: Fix RC verification script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82561
-----------------------------------------------------------
Ship it!
Master (22871c0) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 5, 2015, 6:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 6:49 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Script has drifted over time, this makes it functional again.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> Ran it and verified 0.8.0.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
> On May 7, 2015, 5:06 p.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
>
> Jake Farrell wrote:
> +1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 5, 2015, 10:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Jake Farrell <jf...@apache.org>.
> On May 7, 2015, 5:06 p.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
+1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 5, 2015, 10:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Kevin Sweeney <ke...@apache.org>.
> On May 7, 2015, 10:06 a.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
>
> Jake Farrell wrote:
> +1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
>
> Bill Farner wrote:
> The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here.
>
> Kevin Sweeney wrote:
> This is a complete duplication of the gradle wrapper. Is there a way we can include this standard tool rather than reinvent it?
>
> Bill Farner wrote:
> Help me out here, guys.
> I'm trying to balance the strict requirement to not include binaries in the source distributions with the strict gradle version check in the build. Kevin, Jake - how do you suggest i proceed?
jfarrell suggested parsing gradle.properties to get the GRADLE_VERSION in use on IRC. I'm +1 to that approach.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 5, 2015, 3:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Kevin Sweeney <ke...@apache.org>.
> On May 7, 2015, 10:06 a.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
>
> Jake Farrell wrote:
> +1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
>
> Bill Farner wrote:
> The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here.
This is a complete duplication of the gradle wrapper. Is there a way we can include this standard tool rather than reinvent it?
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 5, 2015, 3:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
> On May 7, 2015, 5:06 p.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
>
> Jake Farrell wrote:
> +1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
>
> Bill Farner wrote:
> The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here.
>
> Kevin Sweeney wrote:
> This is a complete duplication of the gradle wrapper. Is there a way we can include this standard tool rather than reinvent it?
Help me out here, guys.
I'm trying to balance the strict requirement to not include binaries in the source distributions with the strict gradle version check in the build. Kevin, Jake - how do you suggest i proceed?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 5, 2015, 10:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
> On May 7, 2015, 5:06 p.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> > Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
>
> Jake Farrell wrote:
> +1 to the patch other than the gradle download, since we all ready depend on vagrant in the e2e test done see why we cant make gradle a similar required dependency
>
> Bill Farner wrote:
> The issue becomes the current strict gradle version check. I will change the gradle version check to be less strict, which will make me comfortable with using the system-installed gradle here.
>
> Kevin Sweeney wrote:
> This is a complete duplication of the gradle wrapper. Is there a way we can include this standard tool rather than reinvent it?
>
> Bill Farner wrote:
> Help me out here, guys.
> I'm trying to balance the strict requirement to not include binaries in the source distributions with the strict gradle version check in the build. Kevin, Jake - how do you suggest i proceed?
>
> Kevin Sweeney wrote:
> jfarrell suggested parsing gradle.properties to get the GRADLE_VERSION in use on IRC. I'm +1 to that approach.
Done in the latest revision.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
On May 7, 2015, 8:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 8:20 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------
build-support/release/verify-release-candidate
<https://reviews.apache.org/r/33854/#comment133674>
Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency
- Jake Farrell
On May 5, 2015, 10:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82893
-----------------------------------------------------------
Ship it!
Master (fef7194) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 7, 2015, 8:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 8:20 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/
-----------------------------------------------------------
(Updated May 7, 2015, 9 p.m.)
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
Diffs
-----
build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
Diff: https://reviews.apache.org/r/33854/diff/
Testing (updated)
-------
Successfully ran `./build-support/release/verify-release-candidate 0.8.0-rc0`.
Thanks,
Bill Farner
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82898
-----------------------------------------------------------
Ship it!
Ship It!
- Jake Farrell
On May 7, 2015, 8:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 8:20 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82894
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 7, 2015, 1:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 1:20 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/
-----------------------------------------------------------
(Updated May 7, 2015, 8:20 p.m.)
Review request for Aurora and Jake Farrell.
Changes
-------
Pulling gradle bootstrap version from buildSrc/gradle.properties.
Repository: aurora
Description
-------
This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
Diffs (updated)
-----
build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
Diff: https://reviews.apache.org/r/33854/diff/
Testing
-------
TODO(wfarner): Report back results of run against 0.8.0-rc0
Thanks,
Bill Farner
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82595
-----------------------------------------------------------
Ship it!
Master (d3b6e13) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 5, 2015, 10:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:14 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of run against 0.8.0-rc0
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33854: Fix and enhance RC verification script.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/
-----------------------------------------------------------
(Updated May 5, 2015, 10:14 p.m.)
Review request for Aurora and Jake Farrell.
Summary (updated)
-----------------
Fix and enhance RC verification script.
Repository: aurora
Description (updated)
-------
This makes the verification script more complete, automating the basic set of tests that release voters are expected to run.
Diffs (updated)
-----
build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
Diff: https://reviews.apache.org/r/33854/diff/
Testing (updated)
-------
TODO(wfarner): Report back results of run against 0.8.0-rc0
Thanks,
Bill Farner
Re: Review Request 33854: Fix RC verification script.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/
-----------------------------------------------------------
(Updated May 5, 2015, 6:49 p.m.)
Review request for Aurora and Jake Farrell.
Changes
-------
Made some behavior changes:
- use curl instead of svn checkout
- always expect the RC version on the command line
Repository: aurora
Description
-------
Script has drifted over time, this makes it functional again.
Diffs (updated)
-----
build-support/release/verify-release-candidate 0d4d6e0c01ebe006056198d25b165b9658156653
Diff: https://reviews.apache.org/r/33854/diff/
Testing
-------
Ran it and verified 0.8.0.
Thanks,
Bill Farner
Re: Review Request 33854: Fix RC verification script.
Posted by Jake Farrell <jf...@apache.org>.
there should not be any drift, this is just some cleanup based on us
learning from our first couple releases. Jenkins can not cut release as it
requires committing and signing, but jenkins does currently use the same
build script as this uses to test.
-Jake
On Tue, May 5, 2015 at 2:25 PM, Zameer Manji <zm...@apache.org> wrote:
> To prevent this drift of our release and verification infrastructure,
> should we have CI cut a release tarball and try to verify it with this
> script?
>
> On Tue, May 5, 2015 at 11:14 AM, Bill Farner <wf...@apache.org> wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/33854/
> > -----------------------------------------------------------
> >
> > Review request for Aurora and Jake Farrell.
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > -------
> >
> > Script has drifted over time, this makes it functional again.
> >
> >
> > Diffs
> > -----
> >
> > build-support/release/verify-release-candidate
> > 0d4d6e0c01ebe006056198d25b165b9658156653
> >
> > Diff: https://reviews.apache.org/r/33854/diff/
> >
> >
> > Testing
> > -------
> >
> > Ran it and verified 0.8.0.
> >
> >
> > Thanks,
> >
> > Bill Farner
> >
> > --
> > Zameer Manji
> >
> >
>
Re: Review Request 33854: Fix RC verification script.
Posted by Zameer Manji <zm...@apache.org>.
To prevent this drift of our release and verification infrastructure,
should we have CI cut a release tarball and try to verify it with this
script?
On Tue, May 5, 2015 at 11:14 AM, Bill Farner <wf...@apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Script has drifted over time, this makes it functional again.
>
>
> Diffs
> -----
>
> build-support/release/verify-release-candidate
> 0d4d6e0c01ebe006056198d25b165b9658156653
>
> Diff: https://reviews.apache.org/r/33854/diff/
>
>
> Testing
> -------
>
> Ran it and verified 0.8.0.
>
>
> Thanks,
>
> Bill Farner
>
> --
> Zameer Manji
>
>