[jira] [Commented] (AIRFLOW-6070) On the admin dashboard, the recent tasks column has no tooltip for tasks in 'null' state

["jack (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982535#comment-16982535 ] 

jack commented on AIRFLOW-6070:
-------------------------------

Null / None always need special treatment 
Even though different issues I think this probably has the same roots as https://issues.apache.org/jira/browse/AIRFLOW-4314

> On the admin dashboard, the recent tasks column has no tooltip for tasks in 'null' state
> ----------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6070
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6070
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.2
>         Environment: GCP Composer composer-1.7.5-airflow-1.10.2
>            Reporter: Adam Hopkinson
>            Priority: Trivial
>         Attachments: image-2019-11-26-10-03-40-377.png
>
>
> On the DAGS listing template, the circles in the _Recent Tasks_ column all have a tooltip apart from the second to last - which is for tasks with state = `null`
> !image-2019-11-26-10-03-40-377.png|width=261,height=37!
> I believe this is happening in [this line of code|https://github.com/apache/airflow/blob/0ff9e2307042ba95e69b32e37f2fc767a5fdc36d/airflow/www/templates/airflow/dags.html#L447], which is:
> {{.attr('title', function(d) \{return d.state || 'none'})}}
> I'm not sure why it's not falling back to 'none' - I think it's possibly seeing the value of d.state as the text value 'null' rather than a true null, but then putting that into the title as true null.
> I'm using GCP Composer, so don't have a local instance of Airflow that I can test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)