[GitHub] graceguo-supercat closed pull request #3701: [form-data] Quoting /slice/ form data

[GitBox <gi...@apache.org>]

graceguo-supercat closed pull request #3701: [form-data] Quoting /slice/<slice_id> form data
URL: https://github.com/apache/incubator-superset/pull/3701
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index 23a3993c88..d7c799a635 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -12,6 +12,7 @@
 import re
 import time
 import traceback
+from urllib import parse
 
 import sqlalchemy as sqla
 
@@ -937,7 +938,7 @@ def slice(self, slice_id):
             .format(
                 viz_obj.datasource.type,
                 viz_obj.datasource.id,
-                json.dumps(viz_obj.form_data)
+                parse.quote(json.dumps(viz_obj.form_data)),
             )
         )
         if request.args.get("standalone") == "true":


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services